Issue 12617005: Remove the last ant macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12617005: Remove the last ant macros (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
shashi, Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@delete_cruft4

Visibility:
Public.

More Reviews

Description

Remove the last ant macros Android's build script uses record-build-info to determine when the build type has changed and things need to be rebuilt. We use gyp to tell us when to rebuild things and ant should always do it. Remove this macro and inline the corresponding empty strings. BUG=158821 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188128

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -81 lines)			Patch
	M	build/android/ant/apk-build.xml	View		7 chunks	+3 lines, -81 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

shashi

lgtm https://codereview.chromium.org/12617005/diff/1/build/android/ant/apk-build.xml File build/android/ant/apk-build.xml (left): https://codereview.chromium.org/12617005/diff/1/build/android/ant/apk-build.xml#oldcode772 build/android/ant/apk-build.xml:772: <record-build-info /> nit: can be <target ... /> ...

7 years, 9 months ago (2013-03-13 01:28:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12617005/5001

7 years, 9 months ago (2013-03-14 17:46:06 UTC) #4

Message was sent while issue was closed.

Change committed as 188128

Expand Messages | Collapse Messages