Issue 12614002: Fixing ignored clicks after the 'Undo delete' command in Bookmark manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12614002: Fixing ignored clicks after the 'Undo delete' command in Bookmark manager (Closed)

Created:
7 years, 9 months ago by SeRya

Modified:
7 years, 9 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Context menu handles command in 'mouseup' event. Usually the 'click' event follows immediately after 'mouseup'. swallowDoubleClick worked well in that case (it set initial click count to 0 while handling the 'mouseup' event and then increased it to 1 or above while handling the immediatelly following click). However the 'undo delete' menu item handler prevents firing the 'click' event (I found that commenting out 'updateCanExecute' restores it). It's why next click with click count = 1 was ignored. This code works whether click event follows after mouseup event or not. BUG=172580 TEST=Check the scenario described in the bug. Check doubleclick on a context menu (bug 140364). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186770

Patch Set 1 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	ui/webui/resources/js/cr/ui.js	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/12614002/2001

7 years, 9 months ago (2013-03-07 16:50:59 UTC) #3

Message was sent while issue was closed.

Change committed as 186770

Expand Messages | Collapse Messages