Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 12613003: Update display after the passphrase input fields are reset. (Closed)

Created:
7 years, 9 months ago by Adrian Kuegel
Modified:
7 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Call UpdateDisplay after the passphrase input fields are reset. This fixes the issue that the save passphrase button and the warning label will not be reinitialized. BUG=171370 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187273

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M chrome/browser/resources/options/managed_user_set_passphrase.js View 1 4 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Adrian Kuegel
Hi James, can you please review this changelist?
7 years, 9 months ago (2013-03-07 13:21:06 UTC) #1
James Hawkins
https://codereview.chromium.org/12613003/diff/1/chrome/browser/resources/options/managed_user_set_passphrase.js File chrome/browser/resources/options/managed_user_set_passphrase.js (right): https://codereview.chromium.org/12613003/diff/1/chrome/browser/resources/options/managed_user_set_passphrase.js#newcode26 chrome/browser/resources/options/managed_user_set_passphrase.js:26: var closePage = function(container) { Please move this into ...
7 years, 9 months ago (2013-03-07 18:40:54 UTC) #2
Adrian Kuegel
I uploaded a new patch which addresses your review comment. https://codereview.chromium.org/12613003/diff/1/chrome/browser/resources/options/managed_user_set_passphrase.js File chrome/browser/resources/options/managed_user_set_passphrase.js (right): https://codereview.chromium.org/12613003/diff/1/chrome/browser/resources/options/managed_user_set_passphrase.js#newcode26 ...
7 years, 9 months ago (2013-03-08 08:56:33 UTC) #3
James Hawkins
lgtm
7 years, 9 months ago (2013-03-08 18:03:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/12613003/5001
7 years, 9 months ago (2013-03-11 08:39:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=107217
7 years, 9 months ago (2013-03-11 10:39:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/12613003/5001
7 years, 9 months ago (2013-03-11 10:43:50 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 11:19:04 UTC) #8
Message was sent while issue was closed.
Change committed as 187273

Powered by Google App Engine
This is Rietveld 408576698