Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 1261193002: [MD settings] adding privacy strings (Closed)

Created:
5 years, 4 months ago by dschuyler
Modified:
5 years, 4 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] adding privacy strings This CL adds string entries for privacy settings. They are gathered from looking at the UX mocks at https://folio.googleplex.com/crossettingscody/Privacy-Security-HttpSSL-(Site%20Settings) BUG=517564 Committed: https://crrev.com/fb428e2e26681aa86e438a44538eb61cf3e8eecc Cr-Commit-Position: refs/heads/master@{#341934}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review changes #

Patch Set 3 : merge with master #

Patch Set 4 : another merge with master #

Patch Set 5 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 2 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
dschuyler
5 years, 4 months ago (2015-07-30 00:35:14 UTC) #2
dschuyler
5 years, 4 months ago (2015-07-31 21:18:46 UTC) #4
James Hawkins
https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings.grdp#newcode100 chrome/app/settings_strings.grdp:100: <message name="IDS_SETTINGS_CERTIFICATE_MANAGER_PAGE_TITLE" desc="Name of the certificate manager page which ...
5 years, 4 months ago (2015-07-31 21:19:00 UTC) #5
dschuyler
https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings.grdp#newcode100 chrome/app/settings_strings.grdp:100: <message name="IDS_SETTINGS_CERTIFICATE_MANAGER_PAGE_TITLE" desc="Name of the certificate manager page which ...
5 years, 4 months ago (2015-07-31 21:27:29 UTC) #6
James Hawkins
lgtm
5 years, 4 months ago (2015-07-31 21:32:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/20001
5 years, 4 months ago (2015-07-31 21:34:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/93671)
5 years, 4 months ago (2015-07-31 22:41:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/20001
5 years, 4 months ago (2015-08-01 00:04:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/93743)
5 years, 4 months ago (2015-08-01 00:37:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/40001
5 years, 4 months ago (2015-08-01 00:53:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/93769)
5 years, 4 months ago (2015-08-01 02:05:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/80001
5 years, 4 months ago (2015-08-05 18:29:07 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-05 19:09:54 UTC) #24
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 19:10:33 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fb428e2e26681aa86e438a44538eb61cf3e8eecc
Cr-Commit-Position: refs/heads/master@{#341934}

Powered by Google App Engine
This is Rietveld 408576698