|
|
Created:
5 years, 4 months ago by dschuyler Modified:
5 years, 4 months ago Reviewers:
James Hawkins CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] adding privacy strings
This CL adds string entries for privacy settings. They are gathered from looking at the UX mocks at https://folio.googleplex.com/crossettingscody/Privacy-Security-HttpSSL-(Site%20Settings)
BUG=517564
Committed: https://crrev.com/fb428e2e26681aa86e438a44538eb61cf3e8eecc
Cr-Commit-Position: refs/heads/master@{#341934}
Patch Set 1 #
Total comments: 2
Patch Set 2 : review changes #Patch Set 3 : merge with master #Patch Set 4 : another merge with master #Patch Set 5 : test #Messages
Total messages: 25 (11 generated)
dschuyler@chromium.org changed reviewers: + jhawkins@google.com
dschuyler@chromium.org changed reviewers: + jhawkins@chromium.org - jhawkins@google.com
https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings... chrome/app/settings_strings.grdp:100: <message name="IDS_SETTINGS_CERTIFICATE_MANAGER_PAGE_TITLE" desc="Name of the certificate manager page which allows users to modify SSL certificate settings."> nit: Remove 'TITLE', since how the string is going to be used does not (and generally should not) be reflected in the variable name.
https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1261193002/diff/1/chrome/app/settings_strings... chrome/app/settings_strings.grdp:100: <message name="IDS_SETTINGS_CERTIFICATE_MANAGER_PAGE_TITLE" desc="Name of the certificate manager page which allows users to modify SSL certificate settings."> On 2015/07/31 21:19:00, James Hawkins wrote: > nit: Remove 'TITLE', since how the string is going to be used does not (and > generally should not) be reflected in the variable name. Done.
lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jhawkins@chromium.org Link to the patchset: https://codereview.chromium.org/1261193002/#ps40001 (title: "merge with master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jhawkins@chromium.org Link to the patchset: https://codereview.chromium.org/1261193002/#ps80001 (title: "test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261193002/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/fb428e2e26681aa86e438a44538eb61cf3e8eecc Cr-Commit-Position: refs/heads/master@{#341934} |