Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2238)

Unified Diff: chrome/browser/manifest/manifest_icon_downloader.h

Issue 1261143004: Implement manifest icon downloader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address silly regressions due to switching between Android <-> Linux Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/manifest/manifest_icon_downloader.h
diff --git a/chrome/browser/manifest/manifest_icon_downloader.h b/chrome/browser/manifest/manifest_icon_downloader.h
new file mode 100644
index 0000000000000000000000000000000000000000..bdd1aad03090d3e939e791047ada711c37252f91
--- /dev/null
+++ b/chrome/browser/manifest/manifest_icon_downloader.h
@@ -0,0 +1,66 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MANIFEST_MANIFEST_ICON_DOWNLOADER_H_
+#define CHROME_BROWSER_MANIFEST_MANIFEST_ICON_DOWNLOADER_H_
+
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/memory/ref_counted.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+
+namespace content {
+class WebContents;
+} // namespace content
+
+namespace gfx {
+class Size;
+} // namespace gfx
+
+class GURL;
+
+class ManifestIconDownloader {
+ public:
+ using IconFetchCallback = base::Callback<void(const SkBitmap&)>;
+
+ ManifestIconDownloader() = default;
+ ~ManifestIconDownloader() = default;
+
+ // Downloads the icon located at icon_url. If the file contains multiple icons
gone 2015/08/19 22:21:07 nit: This sounds more like a class comment. Consi
Lalit Maganti 2015/08/20 16:48:00 Done.
+ // then it attempts to pick the one closest in size bigger than or
+ // equal to ideal_icon_size_in_dp, taking into account the density of the
+ // device. If a bigger icon is chosen then, the icon is scaled down to be
+ // equal to ideal_icon_size_in_dp.
+ // Returns whether the download has started. It will return false if the
+ // current context or information do not allow to download the image.
+ bool Download(content::WebContents* web_contents,
+ const GURL& icon_url,
+ int ideal_icon_size_in_dp,
+ const IconFetchCallback& callback);
+
+ private:
+ // Callback run after the manifest icon downloaded successfully or the
+ // download failed.
+ static void OnIconFetched(const int ideal_icon_size_in_px,
+ const IconFetchCallback& callback,
+ int id,
+ int http_status_code,
+ const GURL& url,
+ const std::vector<SkBitmap>& bitmaps,
+ const std::vector<gfx::Size>& sizes);
+
+ static void ScaleIcon(const int ideal_icon_size_in_px,
+ const SkBitmap& bitmap,
+ const IconFetchCallback& callback);
+
+ static int FindClosestBitmapIndex(const int ideal_icon_size_in_px,
+ const std::vector<SkBitmap>& bitmaps);
+
+ friend class ManifestIconDownloaderTest;
+
+ DISALLOW_COPY_AND_ASSIGN(ManifestIconDownloader);
+};
+
+#endif // CHROME_BROWSER_MANIFEST_MANIFEST_ICON_DOWNLOADER_H_

Powered by Google App Engine
This is Rietveld 408576698