Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 12610003: Create the testing profile using the builder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove test exclusion. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index 2205e3bb3850755b55453c84d7ca0f6544e13516..a899ec50a284eb18ed6199671efab76a510ea1d1 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -328,7 +328,8 @@ TEST_F(BrowserCommandControllerTest,
ASSERT_TRUE(testing_profile_manager.SetUp());
// Set up a profile with an off the record profile.
- TestingProfile* profile2 = new TestingProfile();
+ TestingProfile::Builder builder;
+ TestingProfile* profile2 = builder.Build().release();
sky 2013/03/08 16:08:05 I'm not familiar with TestingPRofile::Builder, who
Adrian Kuegel 2013/03/08 16:28:54 Build() returns a scoped_ptr. So I assume with thi
profile2->set_incognito(true);
TestingProfile* profile1 =
testing_profile_manager.CreateTestingProfile("p1");
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698