[android_webview] Build test code against the shell APK.

[android_webview] Build test code against the shell APK.

This change is to fix resource-related issues with the current approach.
We can't include resources in the test_java target to share them between
the shell and test apks, so we need one apk to contain the shell and run
tests against.
To achieve this we apply the same trick as testshell does and build the
test code against the .jar created as a side-effect of building the shell
apk target.
This change completely removes the test_apk target.

BUG=None
TEST=AndroidWebViewTests
TBR=bulach@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190404

[mkosiba (inactive), 2013-03-21 14:14:08]

On 2013/03/21 14:03:38, Martin Kosiba wrote:

The change looks scary, but here is what it does:
1) Moves all assets from javatests/ and test_apk/ to shell/.
2) Moves the activity and app classes from javatests/ to shell/ (as well as a
couple of 'common' classes, which are needed by the activity/app classes)
3) Removes the android_webview_apk target and replaces it with the
android_webview_shell_apk target.
4) Makes the test code build against the .jar, which is produced as a
side-effect of running the android_webview_shell_apk target
5) Updates manifests
6) Removes test code that was switching resource contexts - everything is now in
the 'app' resource context, so no need to do that anymore.

[newt (away), 2013-03-21 18:42:28]

lgtm at a high level, and the resources look like they'll work now.

[joth, 2013-03-22 02:19:24]

lgtm

I also didn't read in detail, but using same pattern as content shell and one
less APK both sgtm.

+torne FYI

[commit-bot: I haz the power, 2013-03-22 16:17:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/12609013/16001

[commit-bot: I haz the power, 2013-03-22 18:24:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/12609013/16001

[commit-bot: I haz the power, 2013-03-22 20:57:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-23 12:48:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/12609013/10051

[commit-bot: I haz the power, 2013-03-23 15:05:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/12609013/10051

[commit-bot: I haz the power, 2013-03-23 20:16:41]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is android_dbg, revision is HEAD

[commit-bot: I haz the power, 2013-03-25 10:49:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/12609013/41001

[bulach, 2013-03-25 11:00:13]

lgtm, thanks! one suggestion below, feel free to do as a follow up (if it makes
sense..)

https://codereview.chromium.org/12609013/diff/41001/android_webview/test/shel...
File android_webview/test/shell/AndroidManifest.xml (right):

https://codereview.chromium.org/12609013/diff/41001/android_webview/test/shel...
android_webview/test/shell/AndroidManifest.xml:21: <activity
android:name="org.chromium.android_webview.test.AndroidWebViewTestRunnerActivity"
nit: not sure if there's a patter for "Aw" versus "AndroidWebView", but this
could probably become "Aw" too?

[mkosiba (inactive), 2013-03-25 11:09:20]

On 2013/03/25 11:00:13, bulach wrote:
> lgtm, thanks! one suggestion below, feel free to do as a follow up (if it
makes
> sense..)
> 
>
https://codereview.chromium.org/12609013/diff/41001/android_webview/test/shel...
> File android_webview/test/shell/AndroidManifest.xml (right):
> 
>
https://codereview.chromium.org/12609013/diff/41001/android_webview/test/shel...
> android_webview/test/shell/AndroidManifest.xml:21: <activity
>
android:name="org.chromium.android_webview.test.AndroidWebViewTestRunnerActivity"
> nit: not sure if there's a patter for "Aw" versus "AndroidWebView", but this
> could probably become "Aw" too?

Thanks!
I'll be landing a follow-up CL to rename a bunch of AndroidWebView* classes to
Aw*.
I don't want to mess with this CL, it's been painful enough to land already.

[commit-bot: I haz the power, 2013-03-25 15:37:47]

Change committed as 190404