Issue 12609006: ui::Layer::SwitchToLayer should finish animations on its old cc::Layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12609006: ui::Layer::SwitchToLayer should finish animations on its old cc::Layer (Closed)

Created:
7 years, 9 months ago by ajuma

Modified:
7 years, 9 months ago

Reviewers:
Ian Vollick

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, cc-bugs_chromium.org, jonathan.backer

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

ui::Layer::SwitchToLayer should finish animations on its old cc::Layer Opacity and transform animations on a ui::Layer are handled by its cc::Layer. This CL ensures that when a ui::Layer changes its cc::Layer, it finishes animations that are being handled by the old cc::Layer. BUG=164206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188291

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -0 lines)			Patch
M	ui/compositor/layer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/compositor/layer.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	ui/compositor/layer_unittest.cc	View	3 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ajuma

Without this fix, a ui::LayerAnimationElement that has dispatched an animation to the old cc::Layer but ...

7 years, 9 months ago (2013-03-15 01:13:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12609006/1

7 years, 9 months ago (2013-03-15 01:41:18 UTC) #3

Message was sent while issue was closed.

Change committed as 188291

Expand Messages | Collapse Messages