Fix source generation for strings that have \$ in them.

runtime/vm/object.cc

Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc	(revision 19996)
+++ runtime/vm/object.cc	(working copy)
@@ -4854,6 +4854,9 @@
             escape_characters = true;
           }
         }
+        if ((literal.CharAt(i) == '$')) {

[Ivan Posva, 2013/03/18 18:12:22]

$ should be a SpecialCharacter and then you would not need this extra handling
here and in other places. Also as it is now if fails to properly escape $ in two
byte strings.

[siva, 2013/03/19 17:08:31]

The raw string processing was interfering with treating this as a Special
character. I have a CL uploaded that always translates raw strings to regular
strings and does not attempt to preserve raw strings as is in the generated
code.

That should avoid this problem.

On 2013/03/18 18:12:22, Ivan Posva wrote:

+          escape_characters = true;
+        }
       }
       if ((prev != Token::kINTERPOL_VAR) && (prev != Token::kINTERPOL_END)) {
         if (is_raw_string) {
@@ -11483,6 +11486,7 @@
     intptr_t index = 0;
     for (intptr_t i = 0; i < len; i++) {
       if (IsSpecialCharacter(*CharAddr(str, i)) ||
+          (!raw_str && (*CharAddr(str, i) == '$')) ||
           (!raw_str && (*CharAddr(str, i) == '\\'))) {
         num_escapes += 1;
       }
@@ -11494,6 +11498,10 @@
         *(CharAddr(dststr, index)) = '\\';
         *(CharAddr(dststr, index + 1)) = SpecialCharacter(*CharAddr(str, i));
         index += 2;
+      } else if (!raw_str && (*CharAddr(str, i) == '$')) {
+        *(CharAddr(dststr, index)) = '\\';
+        *(CharAddr(dststr, index + 1)) = '$';
+        index += 2;
       } else if (!raw_str && (*CharAddr(str, i) == '\\')) {
         *(CharAddr(dststr, index)) = '\\';
         *(CharAddr(dststr, index + 1)) = '\\';