D-Bus Clients for BlueZ 5 API

D-Bus Clients for BlueZ 5 API

Implement the BlueZ 5 D-Bus API in separated clients from the 4.x API
so that we can use them both side-by-side.

BUG=chromium-os:38832
TEST=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190578

[keybuk, 2013-03-12 22:14:34]

wip, posting in case I fall off the mountain ;)

[keybuk, 2013-03-22 01:10:25]

Ready for review, ptal

[satorux1, 2013-03-22 02:00:12]

Looks pretty solid as usual. Will take another look later today.

https://codereview.chromium.org/12605008/diff/8001/DEPS
File DEPS (right):

https://codereview.chromium.org/12605008/diff/8001/DEPS#newcode557
DEPS:557: "@8757d8d77f6ca424d24d0c33fb6956082032c2a5",
it's probably safer to update DEPS in a separate patch.

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
File chromeos/dbus/experimental_bluetooth_adapter_client.h (right):

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_adapter_client.h:27: class CHROMEOS_EXPORT
ExperimentalBluetoothAdapterClient {
"Experimental" is a bit vague. Maybe:

BluetoothAdapterClientForBlueZ5

bluez5::BluetoothAdapterClient (and make the existing one
bluez4::BluetoothAdapterClient)

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_adapter_client.h:61: dbus::Property<uint32>
pairable_timeout;
 pairable_timeout_in_secs? It's often helpful to have a unit in a variable name.

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_adapter_client.h:66: dbus::Property<uint32>
discoverable_timeout;
ditto

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_adapter_client.h:74:
dbus::Property<std::vector<std::string> > uuids;
Is this binary data or hexadecimal strings? would be nice to have some comment.

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
File chromeos/dbus/experimental_bluetooth_agent_manager_client.cc (right):

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_agent_manager_client.cc:44:
bluetooth_agent_manager::kExperimentalBluetoothAgentManagerInterface,
four spaces before the parameter

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
File chromeos/dbus/experimental_bluetooth_agent_service_provider.cc (right):

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_agent_service_provider.cc:238: int16
entered;
more like a matter of taste: initialize them with 0?

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_agent_service_provider.cc:266: uint32
passkey;
ditto.

[keybuk, 2013-03-22 16:48:15]

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
File chromeos/dbus/experimental_bluetooth_adapter_client.h (right):

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_adapter_client.h:27: class CHROMEOS_EXPORT
ExperimentalBluetoothAdapterClient {
"experimental" matched the flag we picked, and saved us having to rename the
existing classes

This is only a temporary doubling - once we switch the backend in ChromeOS we'll
delete the existing ChromeOS backend and rename Experimental* to just
BluetoothAdapterClient

https://codereview.chromium.org/12605008/diff/8001/chromeos/dbus/experimental...
chromeos/dbus/experimental_bluetooth_adapter_client.h:61: dbus::Property<uint32>
pairable_timeout;
On 2013/03/22 02:00:12, satorux1 wrote:
>  pairable_timeout_in_secs? It's often helpful to have a unit in a variable
name.

By convention we've been matching the names of the Properties structure members
to the actual name of the exported property in D-Bus, at least at the *Client
level

And then fixing the name to make more sense at the BluetoothAdapter/Device level
that we expose to the rest of Chrome.

[keybuk, 2013-03-22 17:29:32]

https://codereview.chromium.org/12605008/diff/8001/DEPS
File DEPS (right):

https://codereview.chromium.org/12605008/diff/8001/DEPS#newcode557
DEPS:557: "@8757d8d77f6ca424d24d0c33fb6956082032c2a5",
On 2013/03/22 02:00:12, satorux1 wrote:
> it's probably safer to update DEPS in a separate patch.

getting updated in https://codereview.chromium.org/12674035/ by a third-party

[satorux1, 2013-03-22 22:55:07]

LGTM

[commit-bot: I haz the power, 2013-03-25 18:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/12605008/25001

[commit-bot: I haz the power, 2013-03-25 18:56:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-25 20:58:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/12605008/42001

[commit-bot: I haz the power, 2013-03-25 21:32:25]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-25 21:36:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/12605008/50002

[commit-bot: I haz the power, 2013-03-26 06:54:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/12605008/50002

[commit-bot: I haz the power, 2013-03-26 07:43:03]

Change committed as 190578