Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 12605007: Rename android_build_type to android_webview_build. (Closed)

Created:
7 years, 9 months ago by Torne
Modified:
7 years, 9 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Rename android_build_type to android_webview_build. Rename this gyp variable to something meaningful to better explain what it actually does. BUG=184431 Committed: https://code.google.com/p/v8/source/detail?r=13916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/android.gypi View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
This is a followup to Chromium r187556 which renamed this variable (the old name is ...
7 years, 9 months ago (2013-03-12 11:23:46 UTC) #1
mnaganov (inactive)
Hi Yang, Can you please take a look at this change? This is after a ...
7 years, 9 months ago (2013-03-12 11:51:40 UTC) #2
Yang
On 2013/03/12 11:51:40, Mikhail Naganov (Chromium) wrote: > Hi Yang, > > Can you please ...
7 years, 9 months ago (2013-03-12 12:10:53 UTC) #3
mnaganov (inactive)
On 2013/03/12 12:10:53, Yang wrote: > On 2013/03/12 11:51:40, Mikhail Naganov (Chromium) wrote: > > ...
7 years, 9 months ago (2013-03-12 13:07:19 UTC) #4
Yang
7 years, 9 months ago (2013-03-12 17:35:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r13916 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698