Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Side by Side Diff: content/browser/permissions/permission_service_impl.cc

Issue 1260193009: renderer: implement multiple permission requesting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions-request-multiple
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/permissions/permission_service_impl.h" 5 #include "content/browser/permissions/permission_service_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "content/public/browser/browser_context.h" 8 #include "content/public/browser/browser_context.h"
9 #include "content/public/browser/permission_manager.h" 9 #include "content/public/browser/permission_manager.h"
10 #include "content/public/browser/permission_type.h" 10 #include "content/public/browser/permission_type.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 permission_type, 124 permission_type,
125 context_->render_frame_host(), 125 context_->render_frame_host(),
126 request_id, 126 request_id,
127 GURL(origin), 127 GURL(origin),
128 user_gesture, // TODO(mlamouri): should be removed (crbug.com/423770) 128 user_gesture, // TODO(mlamouri): should be removed (crbug.com/423770)
129 base::Bind(&PermissionServiceImpl::OnRequestPermissionResponse, 129 base::Bind(&PermissionServiceImpl::OnRequestPermissionResponse,
130 weak_factory_.GetWeakPtr(), 130 weak_factory_.GetWeakPtr(),
131 request_id)); 131 request_id));
132 } 132 }
133 133
134 void PermissionServiceImpl::RequestPermissions(
135 mojo::Array<PermissionName> permissions,
136 const mojo::String& origin,
137 bool user_gesture,
138 const PermissionsStatusCallback& callback) {
139 NOTIMPLEMENTED();
140
141 // TODO(lalitm,mlamouri): this is returning the current permission statuses
142 // in order for the call to successfully return. It will be changed later.
143 // See https://crbug.com/516626
144 mojo::Array<PermissionStatus> result(permissions.size());
145 for (size_t i = 0; i < permissions.size(); ++i)
146 result[i] = GetPermissionStatusFromName(permissions[i], GURL(origin));
147 callback.Run(result.Pass());
148 }
149
134 void PermissionServiceImpl::OnRequestPermissionResponse( 150 void PermissionServiceImpl::OnRequestPermissionResponse(
135 int request_id, 151 int request_id,
136 PermissionStatus status) { 152 PermissionStatus status) {
137 PendingRequest* request = pending_requests_.Lookup(request_id); 153 PendingRequest* request = pending_requests_.Lookup(request_id);
138 PermissionStatusCallback callback(request->callback); 154 PermissionStatusCallback callback(request->callback);
139 request->callback.reset(); 155 request->callback.reset();
140 pending_requests_.Remove(request_id); 156 pending_requests_.Remove(request_id);
141 callback.Run(status); 157 callback.Run(status);
142 } 158 }
143 159
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 305
290 PermissionStatusCallback callback = subscription->callback; 306 PermissionStatusCallback callback = subscription->callback;
291 307
292 subscription->callback.reset(); 308 subscription->callback.reset();
293 pending_subscriptions_.Remove(pending_subscription_id); 309 pending_subscriptions_.Remove(pending_subscription_id);
294 310
295 callback.Run(status); 311 callback.Run(status);
296 } 312 }
297 313
298 } // namespace content 314 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/permissions/permission_service_impl.h ('k') | content/child/permissions/permission_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698