Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: base/values.h

Issue 12601006: Removing base::DictionaryValue::key_iterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 8c87844a86cbdd2f6034173c9db593be4dfc9571..ce2f77fc572282df65c983cd996a1c9199df6f79 100644
--- a/base/values.h
+++ b/base/values.h
@@ -336,33 +336,6 @@ class BASE_EXPORT DictionaryValue : public Value {
// Swaps contents with the |other| dictionary.
virtual void Swap(DictionaryValue* other);
- // This class provides an iterator for the keys in the dictionary.
- // It can't be used to modify the dictionary.
- //
- // YOU SHOULD ALWAYS USE THE XXXWithoutPathExpansion() APIs WITH THESE, NOT
- // THE NORMAL XXX() APIs. This makes sure things will work correctly if any
- // keys have '.'s in them.
- class BASE_EXPORT key_iterator
- : private std::iterator<std::input_iterator_tag, const std::string> {
- public:
- explicit key_iterator(ValueMap::const_iterator itr);
- // Not explicit, because this is a copy constructor.
- key_iterator(const key_iterator& rhs);
- key_iterator operator++() {
- ++itr_;
- return *this;
- }
- const std::string& operator*() { return itr_->first; }
- bool operator!=(const key_iterator& other) { return itr_ != other.itr_; }
- bool operator==(const key_iterator& other) { return itr_ == other.itr_; }
-
- private:
- ValueMap::const_iterator itr_;
- };
-
- key_iterator begin_keys() const { return key_iterator(dictionary_.begin()); }
- key_iterator end_keys() const { return key_iterator(dictionary_.end()); }
-
// This class provides an iterator over both keys and values in the
// dictionary. It can't be used to modify the dictionary.
class BASE_EXPORT Iterator {
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698