Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: src/trusted/validator_arm/ncvalidate.cc

Issue 12600034: Provide metadata to validator to allow faster caching. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: First fixes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/ncvalidate.cc
diff --git a/src/trusted/validator_arm/ncvalidate.cc b/src/trusted/validator_arm/ncvalidate.cc
index 2c29ce1ccdd7950bbeb0f69acc39958ed106abf6..ba866796c432bea525f8622b39f778f28be17388 100644
--- a/src/trusted/validator_arm/ncvalidate.cc
+++ b/src/trusted/validator_arm/ncvalidate.cc
@@ -144,8 +144,10 @@ static NaClValidationStatus ApplyValidatorArm(
int stubout_mode,
int readonly_text,
const NaClCPUFeatures *cpu_features,
+ const struct NaClValidationMetadata *metadata,
struct NaClValidationCache *cache) {
/* The ARM validator is currently unsafe w.r.t. caching. */
+ UNREFERENCED_PARAMETER(metadata);
UNREFERENCED_PARAMETER(cache);
CheckAddressAlignAndOverflow((uint8_t *) guest_addr, size);
CheckAddressOverflow(data, size);

Powered by Google App Engine
This is Rietveld 408576698