components: Fix components_tracing.gyp to follow the same pattern of the other gyp files.

components: Rename components_tracing.gyp to follow the same pattern of the other gyp files.

We renamed it to tracing.gyp so it conforms with the other gyp files.

components_tracing_untrusted.gyp was renamed to tracing_untrusted.gyp as well. And left as a separate gyp file as it's built as untrusted nacl and has its own
special build requirements which may conflict with the other .gypi files.

BUG=138280
R=jbauman@chromium.org,joi@chromium.org
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186956

[tfarina, 2013-03-07 23:40:06]

Please, take a look.

[Jói, 2013-03-07 23:41:47]

LGTM

[jbauman, 2013-03-07 23:43:34]

lgtm

[commit-bot: I haz the power, 2013-03-08 00:06:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12599004/1

[commit-bot: I haz the power, 2013-03-08 00:06:33]

Presubmit check for 12599004-1 failed and returned exit status 1.

INFO:root:Found 8 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ppapi/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ppapi/ppapi_ipc_untrusted.gyp
    ppapi/native_client/native_client.gyp
    ppapi/ppapi_proxy_untrusted.gyp
    content/content_common.gypi

[tfarina, 2013-03-08 00:35:32]

TBRing Brett for that.

[commit-bot: I haz the power, 2013-03-08 00:42:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12599004/1

[commit-bot: I haz the power, 2013-03-08 01:12:48]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, googleurl_unittests,
media_unittests, net_unittests, sql_unittests, ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-03-08 01:37:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12599004/20001

[tfarina, 2013-03-08 01:55:59]

Joi, do you understand this error message:

gyp: Some files not reachable, cycle in .gyp file dependency graph detected
involving some or all of:
/b/build/slave/ios_dbg_simulator/build/src/build/all.gyp
/b/build/slave/ios_dbg_simulator/build/src/content/content.gyp
/b/build/slave/ios_dbg_simulator/build/src/components/components.gyp
/b/build/slave/ios_dbg_simulator/build/src/chrome/chrome.gyp
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit
status 1 in /b/build/slave/ios_dbg_simulator/build

It only reproduces on mac and ios. It doesn't reproduce locally though (Linux).

[Jói, 2013-03-08 02:00:38]

I know that on XCode you're not allowed to have dependency cycles
between project.  It seems likely that's what you're hitting.  Not
sure how to fix, but it must have something to do with moving
tracing.gypi into the components.gyp file.

On Thu, Mar 7, 2013 at 5:55 PM,  <tfarina@chromium.org> wrote:
> Joi, do you understand this error message:
>
> gyp: Some files not reachable, cycle in .gyp file dependency graph detected
> involving some or all of:
> /b/build/slave/ios_dbg_simulator/build/src/build/all.gyp
> /b/build/slave/ios_dbg_simulator/build/src/content/content.gyp
> /b/build/slave/ios_dbg_simulator/build/src/components/components.gyp
> /b/build/slave/ios_dbg_simulator/build/src/chrome/chrome.gyp
> Using overrides found in /Users/chrome-bot/.gyp/include.gypi
> Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit
> status 1 in /b/build/slave/ios_dbg_simulator/build
>
> It only reproduces on mac and ios. It doesn't reproduce locally though
> (Linux).
>
> https://codereview.chromium.org/12599004/

[tfarina, 2013-03-08 02:01:09]

Ahh, I see.

My guess it's because we have ../content/content.gyp:content_common in the other
gypi files.

That didn't happen before because tracing doesn't depend on content/.

[Jói, 2013-03-08 02:05:54]

Sounds like the simplest approach is to revert, but perhaps do the
renaming of the .gyp files to conform with the others.

On Thu, Mar 7, 2013 at 6:01 PM,  <tfarina@chromium.org> wrote:
> Ahh, I see.
>
> My guess it's because we have ../content/content.gyp:content_common in the
> other
> gypi files.
>
> That didn't happen before because tracing doesn't depend on content/.
>
>
> https://codereview.chromium.org/12599004/

[commit-bot: I haz the power, 2013-03-08 02:09:37]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, chromedriver2_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, nacl_integration, net_unittests, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[tfarina, 2013-03-08 02:15:29]

On 2013/03/08 02:05:54, Jói wrote:
> Sounds like the simplest approach is to revert, but perhaps do the
> renaming of the .gyp files to conform with the others.
> 
Done. Please, see patch set 3.

[Jói, 2013-03-08 02:22:45]

https://codereview.chromium.org/12599004/diff/21014/components/tracing.gyp
File components/tracing.gyp (right):

https://codereview.chromium.org/12599004/diff/21014/components/tracing.gyp#ne...
components/tracing.gyp:6: {
Suggest adding a comment here, explaining that if you try to move this to
tracing.gypi and include it in components.gyp, you will get the circular
dependency error.

[tfarina, 2013-03-08 02:30:08]

https://codereview.chromium.org/12599004/diff/21014/components/tracing.gyp
File components/tracing.gyp (right):

https://codereview.chromium.org/12599004/diff/21014/components/tracing.gyp#ne...
components/tracing.gyp:6: {
On 2013/03/08 02:22:45, Jói wrote:
> Suggest adding a comment here, explaining that if you try to move this to
> tracing.gypi and include it in components.gyp, you will get the circular
> dependency error.

Done.

[Jói, 2013-03-08 02:32:17]

LGTM, thanks.

[commit-bot: I haz the power, 2013-03-08 02:42:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12599004/3002

[commit-bot: I haz the power, 2013-03-08 06:32:14]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-03-08 10:14:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12599004/3002

[commit-bot: I haz the power, 2013-03-08 14:02:54]

Change committed as 186956