Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1259823003: [Android] Allows tabs to be exposed in stacking mode with a mouse (Closed)

Created:
5 years, 4 months ago by varkha
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Allows tabs to be exposed in stacking mode with a mouse Checks if a tab is fully visible before activating reorder mode for mouse drags. This allows the staked mode to be still usable with a mouse. BUG=472318 Committed: https://crrev.com/c7e96732da26156fe16b15c6f98114f5b25326b1 Cr-Commit-Position: refs/heads/master@{#340994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
varkha
dtrainor@, PTAL. This is one of the approaches to fix regression in https://chromiumcodereview.appspot.com/1261443002/. Thanks!
5 years, 4 months ago (2015-07-29 18:24:09 UTC) #2
David Trainor- moved to gerrit
This workaround seems fine to me for now :). I'd need to play with it ...
5 years, 4 months ago (2015-07-29 20:57:56 UTC) #3
varkha
Thanks. I'll land it and watch for the feedback on this.
5 years, 4 months ago (2015-07-29 21:01:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259823003/1
5 years, 4 months ago (2015-07-29 21:03:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 21:49:18 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 21:49:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7e96732da26156fe16b15c6f98114f5b25326b1
Cr-Commit-Position: refs/heads/master@{#340994}

Powered by Google App Engine
This is Rietveld 408576698