Issue 12598009: Simplify ant signing/zipalign code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12598009: Simplify ant signing/zipalign code (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
shashi, Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@delete_cruft2

Visibility:
Public.

More Reviews

Description

Simplify ant signing/zipalign code We always sign and zipalign our apks. Remove code that deals with different possibilities (i.e. asking for password, manually signing/aligning). NOTRY=true BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187953

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -74 lines)			Patch
	M	build/android/ant/apk-build.xml	View		4 chunks	+25 lines, -74 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12598009/5001

7 years, 9 months ago (2013-03-13 21:42:25 UTC) #4

Message was sent while issue was closed.

Change committed as 187953

Expand Messages | Collapse Messages