Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 12598005: [Android] Use generated JNI bindings for locale utils. (Closed)

Created:
7 years, 9 months ago by Yaron
Modified:
7 years, 9 months ago
Reviewers:
bulach, Xianzhu
CC:
chromium-reviews, erikwright+watch_chromium.org, Kibeom Kim (inactive)
Visibility:
Public.

Description

[Android] Use generated JNI bindings for locale utils. We're removing the often error-prone manual bindings with the JNI generator. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M base/android/java/src/org/chromium/base/LocaleUtils.java View 1 chunk +10 lines, -0 lines 0 comments Download
M base/android/locale_utils.cc View 3 chunks +9 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yaron
wangxianzhu: Is there an easy way to test? I've tried changing to an RTL language ...
7 years, 9 months ago (2013-03-12 20:59:20 UTC) #1
Yaron
friendly ping
7 years, 9 months ago (2013-03-13 18:14:14 UTC) #2
Xianzhu
LGTM. I think it's ok not to have written test for this because it's simple ...
7 years, 9 months ago (2013-03-13 18:20:12 UTC) #3
bulach
lgtm, sorry about the delay.
7 years, 9 months ago (2013-03-14 11:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12598005/1
7 years, 9 months ago (2013-03-14 15:48:24 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-14 15:55:22 UTC) #6
Message was sent while issue was closed.
Change committed as 188087

Powered by Google App Engine
This is Rietveld 408576698