Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 12598004: Fix empty candidate window for IME Extension API. (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka
Modified:
7 years, 9 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix empty candidate window for IME Extension API. The problem is that some engines are never deactivated when the engine is switched. The original IBus spec assumes each engine instance will be created on CreateEngine method and destroyed on Destroy function. However in the case of Chrome, we switch the engine instance at the next CreateEngine function and no-op for Destroy function. This is ideally okay because there is only one engine instance. However ibus-daemon sends "Disable" message *AFTER* CreateEngine function, so Extension IME missed it, this is the root cause. I changed to calling "Disable" function at the instance switching and it fixes this problem. BUG=182916 TEST=Manually checked on lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chromeos/dbus/ibus/ibus_engine_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
7 years, 9 months ago (2013-03-12 09:47:51 UTC) #1
Zachary Kuznia
lgtm
7 years, 9 months ago (2013-03-12 11:49:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12598004/1
7 years, 9 months ago (2013-03-12 12:17:30 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-12 17:01:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12598004/1
7 years, 9 months ago (2013-03-12 17:51:09 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-12 22:58:22 UTC) #6
Message was sent while issue was closed.
Change committed as 187680

Powered by Google App Engine
This is Rietveld 408576698