Update activation flow for lte devices not to show 3G loading page.

Update activation flow for lte devices not to show 3G loading page.

->remove the page flash at the start of the activation.
->when we detect there is no network connection show the page asking the user to
connect to WiFi
->if the payment frame load fails, don't attempt reconnect (as it will fail for
networks that should be activated over non-cellular network)

TEST=try disconnecting network at various stages of lte activation and validate
that 'Connect to Wi-Fi to begin' is shown. When the connection is reestablished,
the ui should return to previous state

BUG=176356, 174486
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188290

[tbarzic, 2013-03-14 00:54:16]

please take a look 
(xiyuan for owners review)

[xiyuan, 2013-03-14 01:29:16]

html/js LGTM with nits

https://chromiumcodereview.appspot.com/12597010/diff/2001/chrome/browser/reso...
File chrome/browser/resources/chromeos/mobile_setup.js (right):

https://chromiumcodereview.appspot.com/12597010/diff/2001/chrome/browser/reso...
chrome/browser/resources/chromeos/mobile_setup.js:246:
$('paymentForm').classList.add('hidden');
nit: you can simplify the whole "if" using classList.toggle like this:

$('closeButton').classList.toggle('hidden', !this.paymentShown_);
$('paymentForm').classList.toggle('hidden', !this.paymentShown_);

https://chromiumcodereview.appspot.com/12597010/diff/2001/chrome/browser/reso...
chrome/browser/resources/chromeos/mobile_setup.js:263:
$('paymentForm').classList.add('hidden');
nit: same here.

[tbarzic, 2013-03-14 01:36:28]

https://chromiumcodereview.appspot.com/12597010/diff/2001/chrome/browser/reso...
File chrome/browser/resources/chromeos/mobile_setup.js (right):

https://chromiumcodereview.appspot.com/12597010/diff/2001/chrome/browser/reso...
chrome/browser/resources/chromeos/mobile_setup.js:246:
$('paymentForm').classList.add('hidden');
On 2013/03/14 01:29:17, xiyuan wrote:
> nit: you can simplify the whole "if" using classList.toggle like this:
> 
> $('closeButton').classList.toggle('hidden', !this.paymentShown_);
> $('paymentForm').classList.toggle('hidden', !this.paymentShown_);

cool

https://chromiumcodereview.appspot.com/12597010/diff/2001/chrome/browser/reso...
chrome/browser/resources/chromeos/mobile_setup.js:263:
$('paymentForm').classList.add('hidden');
On 2013/03/14 01:29:17, xiyuan wrote:
> nit: same here.

Done.

[rkc, 2013-03-14 01:55:19]

LGTM - please test the 3g flow also with this new code to ensure nothing broke.

https://chromiumcodereview.appspot.com/12597010/diff/8001/chrome/browser/chro...
File chrome/browser/chromeos/mobile/mobile_activator.h (right):

https://chromiumcodereview.appspot.com/12597010/diff/8001/chrome/browser/chro...
chrome/browser/chromeos/mobile/mobile_activator.h:70:
PLAN_ACTIVATION_WAITING_FOR_CONNECTION = 5,
align with other values.

[tbarzic, 2013-03-14 02:06:07]

no worries, I'll test 3g flow tomorrow..

https://codereview.chromium.org/12597010/diff/8001/chrome/browser/chromeos/mo...
File chrome/browser/chromeos/mobile/mobile_activator.h (right):

https://codereview.chromium.org/12597010/diff/8001/chrome/browser/chromeos/mo...
chrome/browser/chromeos/mobile/mobile_activator.h:70:
PLAN_ACTIVATION_WAITING_FOR_CONNECTION = 5,
On 2013/03/14 01:55:19, Rahul Chaturvedi wrote:
> align with other values.

ohhh, this line did look weird, but I couldn't figure out why :)

[commit-bot: I haz the power, 2013-03-15 02:28:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/12597010/19001

[commit-bot: I haz the power, 2013-03-15 07:41:11]

Change committed as 188290