Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7886)

Unified Diff: chrome/renderer/autofill/form_autofill_util.cc

Issue 12596003: [Autofill] Update tests to support native UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/form_autofill_util.cc
diff --git a/chrome/renderer/autofill/form_autofill_util.cc b/chrome/renderer/autofill/form_autofill_util.cc
index 5af22925310899e097ef17cafdba292a9c25472d..f120c31514e637ac5f4ba732287d19f186055025 100644
--- a/chrome/renderer/autofill/form_autofill_util.cc
+++ b/chrome/renderer/autofill/form_autofill_util.cc
@@ -467,12 +467,9 @@ void ForEachMatchingFormField(const WebFormElement& form_element,
&control_elements);
if (control_elements.size() != data.fields.size()) {
- // This case should be reachable only for pathological websites, which add
- // or remove form fields while the user is interacting with the Autofill
- // popup. I (isherman) am not aware of any such websites, and so am
- // optimistically including a NOTREACHED(). If you ever trip this check,
- // please file a bug against me.
- NOTREACHED();
+ // This case should be reachable only for pathological websites and tests,
+ // which add or remove form fields while the user is interacting with the
+ // Autofill popup.
return;
}

Powered by Google App Engine
This is Rietveld 408576698