Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12596003: [Autofill] Update tests to support native UI (Closed)

Created:
7 years, 9 months ago by Ilya Sherman
Modified:
7 years, 9 months ago
Reviewers:
csharp
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

[Autofill] Update tests to support native UI BUG=171513 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187060

Patch Set 1 #

Total comments: 10

Patch Set 2 : De-nitting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -27 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 1 12 chunks +105 lines, -21 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
7 years, 9 months ago (2013-03-07 08:24:14 UTC) #1
csharp
https://chromiumcodereview.appspot.com/12596003/diff/1/chrome/browser/autofill/autofill_browsertest.cc File chrome/browser/autofill/autofill_browsertest.cc (right): https://chromiumcodereview.appspot.com/12596003/diff/1/chrome/browser/autofill/autofill_browsertest.cc#newcode298 chrome/browser/autofill/autofill_browsertest.cc:298: SendKeyToPageAndWait(ui::VKEY_DOWN, Is this suppose to be different from the ...
7 years, 9 months ago (2013-03-07 14:11:21 UTC) #2
Ilya Sherman
https://chromiumcodereview.appspot.com/12596003/diff/1/chrome/browser/autofill/autofill_browsertest.cc File chrome/browser/autofill/autofill_browsertest.cc (right): https://chromiumcodereview.appspot.com/12596003/diff/1/chrome/browser/autofill/autofill_browsertest.cc#newcode298 chrome/browser/autofill/autofill_browsertest.cc:298: SendKeyToPageAndWait(ui::VKEY_DOWN, On 2013/03/07 14:11:21, csharp wrote: > Is this ...
7 years, 9 months ago (2013-03-07 22:32:16 UTC) #3
csharp
lgtm
7 years, 9 months ago (2013-03-08 14:08:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/12596003/6001
7 years, 9 months ago (2013-03-08 18:59:41 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-08 19:05:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/12596003/6001
7 years, 9 months ago (2013-03-08 19:07:46 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-08 19:14:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/12596003/6001
7 years, 9 months ago (2013-03-08 20:23:46 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 22:48:58 UTC) #10
Message was sent while issue was closed. 
Change committed as 187060

Powered by Google App Engine
This is Rietveld 408576698