Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 12595008: Remove ant stuff dealing with library dependencies (Closed)

Created:
7 years, 9 months ago by cjhopman
Modified:
7 years, 9 months ago
Reviewers:
shashi, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@delete_cruft
Visibility:
Public.

Description

Remove ant stuff dealing with library dependencies This is mostly dealing with the code for library dependencies. Our library dependencies are handled through gyp, and not by ant. The dependency task that is removed calculates only empty paths for each of its arguments (some are already set above and are immutable). BUG=158821 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187911

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -85 lines) Patch
M build/android/ant/apk-build.xml View 9 chunks +4 lines, -85 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cjhopman
7 years, 9 months ago (2013-03-12 23:54:32 UTC) #1
Yaron
lgtm
7 years, 9 months ago (2013-03-13 00:26:25 UTC) #2
shashi
lgtm
7 years, 9 months ago (2013-03-13 01:31:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12595008/1
7 years, 9 months ago (2013-03-13 02:34:55 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=14851
7 years, 9 months ago (2013-03-13 02:55:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12595008/1
7 years, 9 months ago (2013-03-13 15:02:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=15013
7 years, 9 months ago (2013-03-13 15:17:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12595008/38001
7 years, 9 months ago (2013-03-13 18:56:35 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 19:12:24 UTC) #9
Message was sent while issue was closed.
Change committed as 187911

Powered by Google App Engine
This is Rietveld 408576698