Parsing filesystem url before giving it to media player

content/browser/android/media_resource_getter_impl.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/browser/android/cookie_getter_impl.h"
+#include "content/browser/android/media_resource_getter_impl.h"
 
 #include "base/bind.h"
 #include "content/browser/child_process_security_policy_impl.h"
+#include "content/browser/fileapi/browser_file_system_helper.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/content_client.h"
 #include "googleurl/src/gurl.h"
 #include "net/cookies/cookie_monster.h"
 #include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace content {
 
-static void ReturnCookieOnUIThread(
-    const media::CookieGetter::GetCookieCB& callback,
-    const std::string& cookies) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+static void ReturnResultOnUIThread(
+    const base::Callback<void(const std::string&)>& callback,
+    const std::string& result) {
   BrowserThread::PostTask(
-      BrowserThread::UI, FROM_HERE, base::Bind(callback, cookies));
+      BrowserThread::UI, FROM_HERE, base::Bind(callback, result));
 }
 
 // The task object that retrieves cookie on the IO thread.
 // TODO(qinmin): refactor this class to make the code reusable by others as
 // there are lots of duplicated functionalities elsewhere.
 class CookieGetterTask
      : public base::RefCountedThreadSafe<CookieGetterTask> {
  public:
   CookieGetterTask(BrowserContext* browser_context,
                    int renderer_id, int routing_id);
 
   // Called by CookieGetterImpl to start getting cookies for a URL.
   void RequestCookies(
       const GURL& url, const GURL& first_party_for_cookies,
-      const media::CookieGetter::GetCookieCB& callback);
+      const media::MediaResourceGetter::GetCookieCB& callback);
 
  private:
   friend class base::RefCountedThreadSafe<CookieGetterTask>;
   virtual ~CookieGetterTask();
 
   void CheckPolicyForCookies(
       const GURL& url, const GURL& first_party_for_cookies,
-      const media::CookieGetter::GetCookieCB& callback,
+      const media::MediaResourceGetter::GetCookieCB& callback,
       const net::CookieList& cookie_list);
 
   // Context getter used to get the CookieStore.
   net::URLRequestContextGetter* context_getter_;
 
   // Resource context for checking cookie policies.
   ResourceContext* resource_context_;
 
   // Render process id, used to check whether the process can access cookies.
   int renderer_id_;
 
   // Routing id for the render view, used to check tab specific cookie policy.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(CookieGetterTask);
 };
 
 CookieGetterTask::CookieGetterTask(
     BrowserContext* browser_context, int renderer_id, int routing_id)
     : context_getter_(browser_context->GetRequestContext()),
       resource_context_(browser_context->GetResourceContext()),
       renderer_id_(renderer_id),
       routing_id_(routing_id) {
 }
 
 CookieGetterTask::~CookieGetterTask() {}
 
 void CookieGetterTask::RequestCookies(
     const GURL& url, const GURL& first_party_for_cookies,
-    const media::CookieGetter::GetCookieCB& callback) {
+    const media::MediaResourceGetter::GetCookieCB& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   ChildProcessSecurityPolicyImpl* policy =
       ChildProcessSecurityPolicyImpl::GetInstance();
   if (!policy->CanAccessCookiesForOrigin(renderer_id_, url)) {
     callback.Run(std::string());
     return;
   }
 
   net::CookieStore* cookie_store =
       context_getter_->GetURLRequestContext()->cookie_store();
   if (!cookie_store) {
     callback.Run(std::string());
     return;
   }
 
   net::CookieMonster* cookie_monster = cookie_store->GetCookieMonster();
   if (cookie_monster) {
     cookie_monster->GetAllCookiesForURLAsync(url, base::Bind(
         &CookieGetterTask::CheckPolicyForCookies, this,
         url, first_party_for_cookies, callback));
   } else {
     callback.Run(std::string());
   }
 }
 
 void CookieGetterTask::CheckPolicyForCookies(
     const GURL& url, const GURL& first_party_for_cookies,
-    const media::CookieGetter::GetCookieCB& callback,
+    const media::MediaResourceGetter::GetCookieCB& callback,
     const net::CookieList& cookie_list) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (GetContentClient()->browser()->AllowGetCookie(
       url, first_party_for_cookies, cookie_list,
       resource_context_, renderer_id_, routing_id_)) {
     net::CookieStore* cookie_store =
         context_getter_->GetURLRequestContext()->cookie_store();
     cookie_store->GetCookiesWithOptionsAsync(
         url, net::CookieOptions(), callback);
   } else {
     callback.Run(std::string());
   }
 }
 
-CookieGetterImpl::CookieGetterImpl(
-    BrowserContext* browser_context, int renderer_id, int routing_id)
+// The task object that retrieves platform path on the FILE thread.
+class PlatformPathGetterTask
+    : public base::RefCountedThreadSafe<PlatformPathGetterTask> {
+ public:
+  PlatformPathGetterTask(fileapi::FileSystemContext* file_system_context,
+                         int renderer_id);
+
+  // Called by MediaResourceGetterImpl to get the platform path from a file
+  // system URL.
+  void RequestPlaformPath(
+      const GURL& url,
+      const media::MediaResourceGetter::GetPlatformPathCB& callback);
+
+ private:
+  friend class base::RefCountedThreadSafe<PlatformPathGetterTask>;
+  virtual ~PlatformPathGetterTask();
+
+  // File system context for getting the platform path.
+  fileapi::FileSystemContext* file_system_context_;
+
+  // Render process id, used to check whether the process can access the URL.
+  int renderer_id_;
+
+  DISALLOW_COPY_AND_ASSIGN(PlatformPathGetterTask);
+};
+
+PlatformPathGetterTask::PlatformPathGetterTask(
+    fileapi::FileSystemContext* file_system_context, int renderer_id)
+    : file_system_context_(file_system_context),
+      renderer_id_(renderer_id) {
+}
+
+PlatformPathGetterTask::~PlatformPathGetterTask() {}
+
+void PlatformPathGetterTask::RequestPlaformPath(
+    const GURL& url,
+    const media::MediaResourceGetter::GetPlatformPathCB& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+  base::FilePath platform_path;
+  SyncGetPlatformPath(file_system_context_,

[palmer, 2013/03/18 19:54:34]

At some point, possibly here or inside SyncGetPlatformPath, we need to impose
some restrictions on the resulting pathname. We should refuse to open paths that
are outside the /sdcard directory (or equivalent). Talk to nileshagrawal.

[qinmin, 2013/03/18 22:27:59]

For filesystem url, the data are actually stored under app data directory, not
external storage. Added a check to see if the platform_path is a child of app
data dir.

On 2013/03/18 19:54:34, Chris P. wrote:

+                      renderer_id_,
+                      url,
+                      &platform_path);
+  callback.Run(platform_path.value());
+}
+
+MediaResourceGetterImpl::MediaResourceGetterImpl(
+    BrowserContext* browser_context,
+    fileapi::FileSystemContext* file_system_context,
+    int renderer_id, int routing_id)
     : browser_context_(browser_context),
+      file_system_context_(file_system_context),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_this_(this)),
       renderer_id_(renderer_id),
       routing_id_(routing_id) {
 }
 
-CookieGetterImpl::~CookieGetterImpl() {}
+MediaResourceGetterImpl::~MediaResourceGetterImpl() {}
 
-void CookieGetterImpl::GetCookies(const std::string& url,
-                                  const std::string& first_party_for_cookies,
+void MediaResourceGetterImpl::GetCookies(const GURL& url,
+                                  const GURL& first_party_for_cookies,

[palmer, 2013/03/18 19:54:34]

I'm new to this area of code; please forgive my ignorance.  Is there some chance
that we'll include cookies in requests for URLs that resolve to a local file
path? That wouldn't make any sense.

[qinmin, 2013/03/18 22:27:59]

added a line in MediaPlayerBridge ctor to set has_cookies_ to true for
FileSystem URLs so that we will by pass GetCookies call here.

On 2013/03/18 19:54:34, Chris P. wrote:

                                   const GetCookieCB& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   scoped_refptr<CookieGetterTask> task = new CookieGetterTask(
       browser_context_, renderer_id_, routing_id_);
 
-  GetCookieCB cb = base::Bind(
-      &CookieGetterImpl::GetCookiesCallback, weak_this_.GetWeakPtr(), callback);
+  GetCookieCB cb = base::Bind(&MediaResourceGetterImpl::GetCookiesCallback,
+                              weak_this_.GetWeakPtr(), callback);
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&CookieGetterTask::RequestCookies,
-                 task, GURL(url), GURL(first_party_for_cookies),
-                 base::Bind(&ReturnCookieOnUIThread, cb)));
+                 task, url, first_party_for_cookies,
+                 base::Bind(&ReturnResultOnUIThread, cb)));
 }
 
-void CookieGetterImpl::GetCookiesCallback(
+void MediaResourceGetterImpl::GetCookiesCallback(
     const GetCookieCB& callback, const std::string& cookies) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   callback.Run(cookies);
 }
 
+void MediaResourceGetterImpl::GetPlatformPathFromFileSystemURL(
+      const GURL& url, const GetPlatformPathCB& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  scoped_refptr<PlatformPathGetterTask> task = new PlatformPathGetterTask(
+      file_system_context_, renderer_id_);
+
+  GetPlatformPathCB cb = base::Bind(
+      &MediaResourceGetterImpl::GetPlatformPathCallback,
+      weak_this_.GetWeakPtr(), callback);
+  BrowserThread::PostTask(
+      BrowserThread::FILE,
+      FROM_HERE,
+      base::Bind(&PlatformPathGetterTask::RequestPlaformPath,
+                 task, url,
+                 base::Bind(&ReturnResultOnUIThread, cb)));
+}
+
+void MediaResourceGetterImpl::GetPlatformPathCallback(
+    const GetPlatformPathCB& callback, const std::string& platform_path) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  callback.Run(platform_path);
+}
+
 }  // namespace content