Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 12594021: Android: fixes jni_generator for @CalledByNative with generics. (Closed)

Created:
7 years, 9 months ago by bulach
Modified:
7 years, 9 months ago
Reviewers:
nilesh
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: fixes jni_generator for @CalledByNative with generics. While at it, converge naming convention on the matching group. BUG= TEST=base/android/jni_generator_tests.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M base/android/jni_generator/jni_generator.py View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 12 chunks +46 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
ptal
7 years, 9 months ago (2013-03-25 19:17:38 UTC) #1
nilesh
LGTM
7 years, 9 months ago (2013-03-25 19:19:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12594021/1
7 years, 9 months ago (2013-03-25 19:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12594021/1
7 years, 9 months ago (2013-03-26 06:54:21 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 07:32:41 UTC) #5
Message was sent while issue was closed.
Change committed as 190576

Powered by Google App Engine
This is Rietveld 408576698