Alternate NTP Mac: Push down overlay in presentation mode

Alternate NTP Mac: Push down overlay in presentation mode

In presentation mode the browser toolbar and bookmark bar are in a
special floating view. This view obscures the instant overlay since
the overlay is at the top of the screen.

This CL pushes the overlay down so that it's not obscured when the
floating toolbar view is shown.

Test build: https://docs.google.com/file/d/0B0Odde3V7EhWTmtMTXBJYmtGS3M/edit?usp=sharing

BUG=167185
TEST=
  Launched Chrome with instant extended enabled.
  Enter presentation mode and type in the omnibox.
  Verify that the omnibox popup is below the floating toolbar view.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190980

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191048

[kuan, 2013-03-25 15:24:11]

lgtm.

[dhollowa, 2013-03-25 16:28:18]

LGTM w/ nits and question.

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
File chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm (right):

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm:317: // Verify
that in presentation mode, instant search results are below the
nit: "Instant"

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:254: // down by so
that it doesn't get covered by the floating toolbar.
"pushed down so"

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:263: // infobar (or
bookmark bar if there's no infobar). This is used to push
What if there's both the bookmark bar and the infobar?

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:879: // Normal
mode, keep the tab web contents at the top (below the info bar).
nit: "infobar"

[sail, 2013-03-26 00:16:43]

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
File chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm (right):

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm:317: // Verify
that in presentation mode, instant search results are below the
On 2013/03/25 16:28:18, dhollowa wrote:
> nit: "Instant"

Done.

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:254: // down by so
that it doesn't get covered by the floating toolbar.
On 2013/03/25 16:28:18, dhollowa wrote:
> "pushed down so"

Done.

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:263: // infobar (or
bookmark bar if there's no infobar). This is used to push
On 2013/03/25 16:28:18, dhollowa wrote:
> What if there's both the bookmark bar and the infobar?

contentAreaTop is the Y coordinate of the bottom most bar. Updated comment to
explain this.

https://codereview.chromium.org/12594015/diff/8001/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:879: // Normal
mode, keep the tab web contents at the top (below the info bar).
On 2013/03/25 16:28:18, dhollowa wrote:
> nit: "infobar"

Actually, we always make this two words. Updated my other comments so it's
consistent.

[commit-bot: I haz the power, 2013-03-26 00:43:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/12594015/15001

[commit-bot: I haz the power, 2013-03-26 17:09:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/12594015/15001

[commit-bot: I haz the power, 2013-03-27 18:13:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/12594015/15001

[commit-bot: I haz the power, 2013-03-27 18:15:33]

Change committed as 190980

[commit-bot: I haz the power, 2013-03-27 18:44:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/12594015/37001

[commit-bot: I haz the power, 2013-03-27 22:19:19]

Change committed as 191048