Instant: Possible fix for crash.

chrome/browser/instant/instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_controller.h"
 
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 613 matching lines @@
       "last_match_was_search_=%d instant_tab_=%d", type,
       UTF16ToUTF8(last_omnibox_text_).c_str(), last_match_was_search_,
       instant_tab_ != NULL));
 
   // If we are on an already committed search results page, send a submit event
   // to the page, but otherwise, nothing else to do.
   if (instant_tab_) {
     if (type == INSTANT_COMMIT_PRESSED_ENTER &&
         (last_match_was_search_ ||
          last_suggestion_.behavior == INSTANT_COMPLETE_NEVER)) {
-      EnsureSearchTermsAreSet(instant_tab_->contents(), last_omnibox_text_);
+      last_suggestion_.text.clear();

[Jered, 2013/03/17 17:43:38]

Why do this?

[sreeram, 2013/03/17 17:53:27]

Line 636 calls Focus() on the web contents. I assumed this might lead to
OmniboxLostFocus(), which will try to "commit" the suggested text (gray text),
since all of the conditions in that 'if' statement will be true.

Incidentally, this also fixes http://crbug.com/196811.

All this is in theory. I haven't actually duplicated the crash, or verified that
this actually fixes anything. We'll know soon.

       instant_tab_->Submit(last_omnibox_text_);
       instant_tab_->contents()->GetView()->Focus();
+      EnsureSearchTermsAreSet(instant_tab_->contents(), last_omnibox_text_);
       return true;
     }
     return false;
   }
 
   // If the overlay is not showing at all, don't commit it.
   if (!model_.mode().is_search_suggestions())
     return false;
 
   // If the overlay is showing at full height (with results), commit it.
@@ skipping 925 matching lines @@
       // for instance, if the user types 'i' and the suggestion is 'INSTANT',
       // suggest 'nstant'. Otherwise, the user text really isn't a prefix, so
       // suggest nothing.
       // TODO(samarth|jered): revisit this logic. http://crbug.com/196572.
       return true;
     }
   }
 
   return false;
 }