Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12593006: Fix GPU overflow (Closed)

Created:
7 years, 9 months ago by jln (very slow on Chromium)
Modified:
7 years, 9 months ago
Reviewers:
marcheu, Pawel Osciak
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/common/gpu/media/h264_parser.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Pawel Osciak
https://codereview.chromium.org/12593006/diff/1/content/common/gpu/media/h264_parser.cc File content/common/gpu/media/h264_parser.cc (right): https://codereview.chromium.org/12593006/diff/1/content/common/gpu/media/h264_parser.cc#newcode463 content/common/gpu/media/h264_parser.cc:463: CHECK_EQ(arraysize(sps->scaling_list4x4[i]), kH264ScalingList4x4Length); I don't see how this check would ...
7 years, 9 months ago (2013-03-08 02:37:53 UTC) #1
Pawel Osciak
lgtm
7 years, 9 months ago (2013-03-08 02:43:24 UTC) #2
marcheu
LGTM. I'm checking the commit box.
7 years, 9 months ago (2013-03-08 03:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/12593006/6001
7 years, 9 months ago (2013-03-08 03:33:42 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 05:42:39 UTC) #5
Message was sent while issue was closed. 
Change committed as 186899

Powered by Google App Engine
This is Rietveld 408576698