Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: chrome/test/data/extensions/api_test/tabs/on_updated/test.js

Issue 12591008: Trigger a tab updated event if the favicon URL changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove favicon.ico (was committed separately). Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/tabs/on_updated/favicon/a.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/tabs/on_updated/test.js
diff --git a/chrome/test/data/extensions/api_test/tabs/on_updated/test.js b/chrome/test/data/extensions/api_test/tabs/on_updated/test.js
index 2cebb24b0b36a6df674cdfef78e6061de2e10f91..05bf7e97bbff827b125fda2d6680e74faccd20b7 100644
--- a/chrome/test/data/extensions/api_test/tabs/on_updated/test.js
+++ b/chrome/test/data/extensions/api_test/tabs/on_updated/test.js
@@ -24,7 +24,8 @@ function checkExpectations() {
var getURL = chrome.extension.getURL;
chrome.tabs.onUpdated.addListener(function(tabId, info, tab) {
- console.log('---onUpdated: ' + info.status + ', ' + info.url);
+ console.log('---onUpdated: ' + info.status + ', ' + info.url + '. ' +
+ info.favIconUrl);
if (shouldIgnore && shouldIgnore(info)) {
return;
}
@@ -108,5 +109,15 @@ chrome.test.runTests([
]);
chrome.tabs.create({ url: getURL('internalAnchorNavigated/a.html') });
+ },
+
+ function faviconLoaded() {
+ expect([
+ { status: 'loading', url: getURL('favicon/a.html') },
+ { status: 'complete' },
+ { favIconUrl: getURL('favicon/favicon.ico') },
+ ]);
+
+ chrome.tabs.create({ url: getURL('favicon/a.html') });
}
]);
« no previous file with comments | « chrome/test/data/extensions/api_test/tabs/on_updated/favicon/a.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698