Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12589003: Remove duplicated code from chrome://inspect implementation (Closed)

Created:
7 years, 9 months ago by Vladislav Kaznacheev
Modified:
7 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@targets
Visibility:
Public.

Description

Remove duplicated code from chrome://inspect implementation BUG=None TBR=jhawkins Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187854

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M chrome/browser/ui/webui/inspect_ui.cc View 1 2 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vladislav Kaznacheev
Please review
7 years, 9 months ago (2013-03-12 09:24:34 UTC) #1
pfeldman
lgtm
7 years, 9 months ago (2013-03-12 09:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/12589003/2001
7 years, 9 months ago (2013-03-12 09:40:33 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-12 11:22:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/12589003/2001
7 years, 9 months ago (2013-03-12 12:32:41 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-12 12:41:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/12589003/25001
7 years, 9 months ago (2013-03-13 08:57:26 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 13:27:46 UTC) #8
Message was sent while issue was closed. 
Change committed as 187854

Powered by Google App Engine
This is Rietveld 408576698