Chromium Code Reviews| Index: chrome/browser/autofill/autofill_metrics.h |
| diff --git a/chrome/browser/autofill/autofill_metrics.h b/chrome/browser/autofill/autofill_metrics.h |
| index 87dcf8831bfde7c7f96f1f1fb073c6de199ce04f..98fe171cb282cb6184893e26098c3e139b38fc86 100644 |
| --- a/chrome/browser/autofill/autofill_metrics.h |
| +++ b/chrome/browser/autofill/autofill_metrics.h |
| @@ -64,6 +64,22 @@ class AutofillMetrics { |
| NUM_DIALOG_SECURITY_METRICS |
| }; |
| + // The initial state of user that's interacting with a freshly shown |
| + // requestAutocomplete or Autocheckout dialog. |
| + enum DialogInitialUserStateMetric { |
| + // User not signed in, no verified Autofill profiles. |
| + DIALOG_NEW_USER_NOT_SIGNED_IN = 0, |
|
Dan Beam
2013/03/07 17:16:50
is a user "new" if this is their *first* (and only
Ilya Sherman
2013/03/09 01:58:57
No, it's as the comment says. Do you have a diffe
|
| + // User signed in, no Wallet items, no verified Autofill profiles. |
| + DIALOG_NEW_USER_SIGNED_IN, |
| + // User signed in, no Wallet items, but 1+ verified Autofill profiles. |
|
Dan Beam
2013/03/07 17:16:50
nit: if you could change "1+" to something that do
Ilya Sherman
2013/03/09 01:58:57
Done.
|
| + DIALOG_AUTOFILL_USER_SIGNED_IN, |
| + // User signed in, 1+ Wallet items. |
| + DIALOG_WALLET_USER_SIGNED_IN, |
| + // User not signed in, but 1+ verified Autofill profiles. |
| + DIALOG_AUTOFILL_USER_NOT_SIGNED_IN, |
| + NUM_DIALOG_INITIAL_USER_STATE_METRICS |
| + }; |
| + |
| enum InfoBarMetric { |
| INFOBAR_SHOWN = 0, // We showed an infobar, e.g. prompting to save credit |
| // card info. |
| @@ -247,6 +263,13 @@ class AutofillMetrics { |
| autofill::DialogType dialog_type, |
| DialogDismissalAction dismissal_action) const; |
| + // This should be called as soon as the user's signed-in status and Wallet |
| + // item count is known. Records that a starting out in |user_state| is |
| + // interacting with a dialog of |dialog_type|. |
| + virtual void LogDialogInitialUserState( |
| + autofill::DialogType dialog_type, |
| + DialogInitialUserStateMetric user_type) const; |
| + |
| // For tracking Wallet errors that occur while a dialog of type |dialog_type| |
| // is showing. |
| virtual void LogWalletErrorMetric(autofill::DialogType dialog_type, |