cc: Rename PictureLayerTiling(Set) Iterator to CoverageIterator

cc: Rename PictureLayerTiling(Set) Iterator to CoverageIterator

Both of the PLT and PLTSet iterators are specific to geometry coverage
of some rect.  Calling them CoverageIterator makes this more clear.

R=danakj@chromium.org
BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191218

[danakj, 2013-03-27 23:52:58]

LGTM!

https://codereview.chromium.org/12583018/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/12583018/diff/1/cc/layers/picture_layer_impl....
cc/layers/picture_layer_impl.cc:525: for (PictureLayerTiling::CoverageIterator
nit: is this wrapping super weird or is it just me? i'd have expected it to wrap
at the ( or at the ,s

[enne (OOO), 2013-03-28 17:45:07]

https://codereview.chromium.org/12583018/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/12583018/diff/1/cc/layers/picture_layer_impl....
cc/layers/picture_layer_impl.cc:525: for (PictureLayerTiling::CoverageIterator
On 2013/03/27 23:52:58, danakj wrote:
> nit: is this wrapping super weird or is it just me? i'd have expected it to
wrap
> at the ( or at the ,s

Yeah, that is really unexpected.  Filed http://b/8498792 and fixed here.

[commit-bot: I haz the power, 2013-03-28 17:45:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12583018/5001

[commit-bot: I haz the power, 2013-03-28 17:45:50]

Failed to apply patch for cc/resources/picture_layer_tiling.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/resources/picture_layer_tiling.h
  Hunk #3 FAILED at 167.
  1 out of 3 hunks FAILED -- saving rejects to file
cc/resources/picture_layer_tiling.h.rej

Patch:       cc/resources/picture_layer_tiling.h
Index: cc/resources/picture_layer_tiling.h
diff --git a/cc/resources/picture_layer_tiling.h
b/cc/resources/picture_layer_tiling.h
index
bc613219fd9809315afa0d9f33326c218d7c7c5d..12b5eff9ecfaa8c18cacc7a0c0f5dceb34592d71
100644
--- a/cc/resources/picture_layer_tiling.h
+++ b/cc/resources/picture_layer_tiling.h
@@ -80,13 +80,13 @@ class CC_EXPORT PictureLayerTiling {
   // (i.e. no valid resource) this tiling should still iterate over them.
   // The union of all geometry_rect calls for each element iterated over should
   // exactly equal content_rect and no two geometry_rects should intersect.
-  class CC_EXPORT Iterator {
+  class CC_EXPORT CoverageIterator {
    public:
-    Iterator();
-    Iterator(const PictureLayerTiling* tiling,
+    CoverageIterator();
+    CoverageIterator(const PictureLayerTiling* tiling,
         float dest_scale,
         gfx::Rect rect);
-    ~Iterator();
+    ~CoverageIterator();
 
     // Visible rect (no borders), always in the space of content_rect,
     // regardless of the contents scale of the tiling.
@@ -102,7 +102,7 @@ class CC_EXPORT PictureLayerTiling {
     Tile* operator->() const { return current_tile_; }
     Tile* operator*() const { return current_tile_; }
 
-    Iterator& operator++();
+    CoverageIterator& operator++();
     operator bool() const { return tile_j_ <= bottom_; }
 
    private:
@@ -167,7 +167,7 @@ class CC_EXPORT PictureLayerTiling {
   int last_source_frame_number_;
   double last_impl_frame_time_;
 
-  friend class Iterator;
+  friend class CoverageIterator;
 };
 
 }  // namespace cc

[commit-bot: I haz the power, 2013-03-28 18:08:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12583018/9001

[commit-bot: I haz the power, 2013-03-28 21:40:27]

Change committed as 191218