Reserve an isolated world ID for Chrome Translate

Reserve an isolated world ID for Chrome Translate

V8 isolated world ID is managed by UserScriptSlave and depends
Extensions. But isolated world is useful for not only Extensions, but
also other features using JavaScript.
Now, Chrome Translate need to use isolated world for running under
Content-Security-Policy.
This change make it possible to reserve some IDs for internal features.

BUG=164547
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191459

[Takashi Toyoshima, 2013-03-27 23:38:00]

Hi Aaron,

Can you take a look this small change?
I'm working on Chrome Translate and want to create an isolated world for
Translate feature to run under content-security-policy. Firstly, I'm going to
move ID management logic outside renderer/extensions, but I notice that it looks
enough to reserve an ID for translate.

FYI, here is a design doc for Translate running under content-security-policy;
https://docs.google.com/a/google.com/document/d/148QU79857mhemyZQq6x0Ic4xgHly...

CC: Mike as a content-security-policy expert.

[Takashi Toyoshima, 2013-03-27 23:47:27]

Oops, Aron doesn't work on Chrome now?
I changed reviewer to mpcomplete@

Can you take a look, or suggest other proper reviewer?

Thanks,

On 2013/03/27 23:38:00, Takashi Toyoshima (chromium) wrote:
> Hi Aaron,
> 
> Can you take a look this small change?
> I'm working on Chrome Translate and want to create an isolated world for
> Translate feature to run under content-security-policy. Firstly, I'm going to
> move ID management logic outside renderer/extensions, but I notice that it
looks
> enough to reserve an ID for translate.
> 
> FYI, here is a design doc for Translate running under content-security-policy;
>
https://docs.google.com/a/google.com/document/d/148QU79857mhemyZQq6x0Ic4xgHly...
> 
> CC: Mike as a content-security-policy expert.

[Matt Perry, 2013-03-28 19:22:35]

LGTM, but it might be simpler for you to use a component extension instead. That
way you'll get the full benefit of the extension infrastructure, and can arrange
for your own content-security-policy for your scripts.

[Mike West, 2013-03-28 19:27:42]

On 2013/03/28 19:22:35, Matt Perry wrote:
> LGTM, but it might be simpler for you to use a component extension instead.
That
> way you'll get the full benefit of the extension infrastructure, and can
arrange
> for your own content-security-policy for your scripts.

I don't think this would solve the problem Translate is running into; as I
understand it, they're not limited by the extension's CSP, but by the CSP of the
page into which they're injecting script. The reason they require an isolated
world is so they can bypass the CSP of the page into which they inject script.

[Matt Perry, 2013-03-28 20:02:52]

On 2013/03/28 19:27:42, Mike West (chromium) wrote:
> On 2013/03/28 19:22:35, Matt Perry wrote:
> > LGTM, but it might be simpler for you to use a component extension instead.
> That
> > way you'll get the full benefit of the extension infrastructure, and can
> arrange
> > for your own content-security-policy for your scripts.
> 
> I don't think this would solve the problem Translate is running into; as I
> understand it, they're not limited by the extension's CSP, but by the CSP of
the
> page into which they're injecting script. The reason they require an isolated
> world is so they can bypass the CSP of the page into which they inject script.

It would still bypass the page's CSP as an extension content script.

[Takashi Toyoshima, 2013-03-28 20:47:10]

I didn't know what component extension is. Do you have any document?

[Matt Perry, 2013-03-28 20:51:38]

On 2013/03/28 20:47:10, Takashi Toyoshima (chromium) wrote:
> I didn't know what component extension is. Do you have any document?

I don't think we have a document. A component extension is an extension built
into the Chrome binary and shipped with Chrome. You put the extension's
manifest.json in a resource file, and it is loaded like a regular extension.
Component extensions get extra privileges beyond user-installed extensions
because we consider them a part of Chrome.

As an example, the bookmark manager is a component extension.

[Takashi Toyoshima, 2013-03-28 21:39:31]

Interesting.
But, if everything should be implemented in JavaScript, I can not adopt it. The
injected translate script need to collaborates with C++ native code.

[Matt Perry, 2013-03-28 21:43:27]

On 2013/03/28 21:39:31, Takashi Toyoshima (chromium) wrote:
> Interesting.
> But, if everything should be implemented in JavaScript, I can not adopt it.
The
> injected translate script need to collaborates with C++ native code.

This is possible. You can add a new private extension API that is only usable to
your extension. That API gives you access to native code.

That said, it may end up being simpler to just go with your current change.

[Takashi Toyoshima, 2013-03-28 21:58:30]

Thank you for useful information.
As a longterm objective, I'm thinking about defining an extension API for
translation to handle dynamic page translation effectively. So, using a
component extension with a private extension API looks good midterm goal for
transition.
But for now, I'd land this change and keep current design because I'd like
Translate to support CSP ASAP.

[Matt Perry, 2013-03-28 22:00:04]

Sounds good. Still lgtm

[commit-bot: I haz the power, 2013-03-28 22:06:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/12583016/18001

[commit-bot: I haz the power, 2013-03-28 22:06:24]

Presubmit check for 12583016-18001 failed and returned exit status 1.

INFO:root:Found 3 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/chrome_renderer.gypi
    chrome/renderer/isolated_world_ids.h

[Takashi Toyoshima, 2013-03-28 22:16:02]

+sky for chrome/OWNERS review

Hi Sky, can you sanctify this change?

[sky, 2013-03-28 22:48:59]

I'm not familiar with this at all, any chance you could find another OWNER that
has a clue?

[Takashi Toyoshima, 2013-03-28 23:46:45]

+brettw

Hi Bred, can you take a look this?
Major part of this change under chrome/renderer/extensions/ is reviewed by
mpcomplete@.
So, I'd like to add one file under chrome/renderer/.

[brettw, 2013-03-29 17:22:48]

LGTM rubberstamp

[commit-bot: I haz the power, 2013-03-29 17:30:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/12583016/18001

[commit-bot: I haz the power, 2013-03-29 22:56:41]

Change committed as 191459