Issue 12583012: Introduce IsMemberOfExtension function into ExtensionIMEUtil.

Issue 12583012: Introduce IsMemberOfExtension function into ExtensionIMEUtil. (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka

Modified:
7 years, 9 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, Aaron Boodman, stevenjb+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduce IsMemberOfExtension function into ExtensionIMEUtil. This function returns if the |input_method_id| is a member of |extension_id|. BUG=164377 TEST=ran chromeos_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190769

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
M	chromeos/ime/extension_ime_util.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chromeos/ime/extension_ime_util.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chromeos/ime/extension_ime_util_unittest.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

https://codereview.chromium.org/12583012/diff/1/chromeos/ime/extension_ime_util.cc File chromeos/ime/extension_ime_util.cc (right): https://codereview.chromium.org/12583012/diff/1/chromeos/ime/extension_ime_util.cc#newcode32 chromeos/ime/extension_ime_util.cc:32: false); // Case insensitive. Why is this case insensitive?

7 years, 9 months ago (2013-03-26 09:17:28 UTC) #2

Seigo Nonaka

7 years, 9 months ago (2013-03-26 09:26:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12583012/5001

7 years, 9 months ago (2013-03-26 16:29:07 UTC) #6

Message was sent while issue was closed.

Change committed as 190769

Expand Messages | Collapse Messages