Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 12580009: look for additional_expectations as well as additional_expectations_files (Closed)

Created:
7 years, 9 months ago by Dirk Pranke
Modified:
7 years, 9 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

look for additional_expectations as well as additional_expectations_files new-run-webkit-tests uses --additional-expectations, and so we should change the factory properties from additional_expectations_files to additional_expectations in order to be consistent. R=ilevy@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
See https://codereview.chromium.org/12927002/ for the motivating change (but this one needs to land first).
7 years, 9 months ago (2013-03-20 01:19:23 UTC) #1
Isaac (away)
lgtm
7 years, 9 months ago (2013-03-20 01:43:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/12580009/1
7 years, 9 months ago (2013-03-20 02:00:06 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 09:34:12 UTC) #4
Message was sent while issue was closed.
Change committed as 189231

Powered by Google App Engine
This is Rietveld 408576698