Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12578027: Removed 'show full history' from navigation popup. Cleaned up associated dead code. (Closed)

Created:
7 years, 9 months ago by apiccion
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-show-full-history-from-menu-222282
Visibility:
Public.

Description

Removed 'show full history' from navigation popup. Cleaned up associated dead code. BUG=222282 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190831

Patch Set 1 #

Patch Set 2 : Removed broken test (checking click on show full history which we removed) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -80 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java View 4 chunks +4 lines, -40 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 1 5 chunks +2 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
David Trainor- moved to gerrit
lgtm
7 years, 9 months ago (2013-03-22 21:40:05 UTC) #1
David Trainor- moved to gerrit
lgtm
7 years, 9 months ago (2013-03-22 21:40:53 UTC) #2
Ted C
lgtm
7 years, 9 months ago (2013-03-22 23:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/12578027/1
7 years, 9 months ago (2013-03-22 23:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/12578027/1
7 years, 9 months ago (2013-03-23 15:04:10 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
7 years, 9 months ago (2013-03-23 21:50:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/12578027/1
7 years, 9 months ago (2013-03-25 23:08:14 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
7 years, 9 months ago (2013-03-26 05:14:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/12578027/1
7 years, 9 months ago (2013-03-27 03:21:42 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=111716
7 years, 9 months ago (2013-03-27 04:04:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apiccion@chromium.org/12578027/57001
7 years, 9 months ago (2013-03-27 04:19:32 UTC) #11
commit-bot: I haz the power
7 years, 9 months ago (2013-03-27 06:43:33 UTC) #12
Message was sent while issue was closed. 
Change committed as 190831

Powered by Google App Engine
This is Rietveld 408576698