Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 12578008: Move CrxFile, FileReader, ExtensionResource to src/extensions. (Closed)

Created:
7 years, 9 months ago by Yoyo Zhou
Modified:
7 years, 9 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tzik+watch_chromium.org, yoshiki+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, Raghu Simha, yuzo+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, haitaol1, ctguil+watch_chromium.org, zork+watch_chromium.org, akalin, hashimoto+watch_chromium.org, tfarina, sail+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, jshin+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move CrxFile, FileReader, ExtensionResource to src/extensions. Also move ExtensionResource to extensions namespace. Also clean up the GenerateId and ShouldLocalizeManfest interfaces. BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190078

Patch Set 1 : #

Total comments: 12

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -1121 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/all_urls_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_user_script_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/crx_file.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/extensions/crx_file.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_image.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_icon_manager_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 9 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/extensions/file_reader.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/extensions/file_reader.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/extensions/file_reader_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M chrome/browser/extensions/image_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 7 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_site_list.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_site_list.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 1 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync/test/integration/themes_helper.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/script_bubble_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/icons/icons_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 1 2 4 chunks +1 line, -29 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 10 chunks +6 lines, -74 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 1 15 chunks +21 lines, -38 lines 0 comments Download
D chrome/common/extensions/extension_resource.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/common/extensions/extension_resource.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/common/extensions/extension_resource_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
M chrome/common/extensions/extension_test_util.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 5 chunks +3 lines, -43 lines 0 comments Download
M chrome/common/extensions/unpacker.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/DEPS View 1 1 chunk +13 lines, -1 line 0 comments Download
A + extensions/browser/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/file_reader.h View 3 chunks +7 lines, -6 lines 0 comments Download
A + extensions/browser/file_reader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + extensions/browser/file_reader_unittest.cc View 3 chunks +8 lines, -9 lines 0 comments Download
D extensions/common/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/constants.h View 1 chunk +14 lines, -0 lines 0 comments Download
M extensions/common/constants.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A + extensions/common/crx_file.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/crx_file.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/extension_resource.h View 2 chunks +7 lines, -3 lines 0 comments Download
A + extensions/common/extension_resource.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + extensions/common/extension_resource_unittest.cc View 6 chunks +11 lines, -8 lines 0 comments Download
A extensions/common/id_util.h View 1 chunk +35 lines, -0 lines 0 comments Download
A extensions/common/id_util.cc View 1 chunk +73 lines, -0 lines 0 comments Download
A extensions/common/id_util_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yoyo Zhou
jyasskin: please review. Sorry it's a lot of files, but the changes are mostly trivial. ...
7 years, 9 months ago (2013-03-22 19:30:30 UTC) #1
Ben Goodger (Google)
rubber stamp lgtm for the move once you have a closer review.
7 years, 9 months ago (2013-03-22 19:32:48 UTC) #2
Yoyo Zhou
On 2013/03/22 19:32:48, Ben Goodger (Google) wrote: > rubber stamp lgtm for the move once ...
7 years, 9 months ago (2013-03-22 19:35:04 UTC) #3
Ben Goodger (Google)
yep saw that one... makes sense. On Fri, Mar 22, 2013 at 12:35 PM, <yoz@chromium.org> ...
7 years, 9 months ago (2013-03-22 19:35:39 UTC) #4
Jeffrey Yasskin
https://codereview.chromium.org/12578008/diff/5005/chrome/browser/sync/test/integration/sync_extension_helper.cc File chrome/browser/sync/test/integration/sync_extension_helper.cc (right): https://codereview.chromium.org/12578008/diff/5005/chrome/browser/sync/test/integration/sync_extension_helper.cc#newcode50 chrome/browser/sync/test/integration/sync_extension_helper.cc:50: std::string SyncExtensionHelper::NameToId(const std::string& name) { Inline this now? https://codereview.chromium.org/12578008/diff/5005/chrome/chrome_browser_extensions.gypi ...
7 years, 9 months ago (2013-03-22 20:26:50 UTC) #5
Yoyo Zhou
https://chromiumcodereview.appspot.com/12578008/diff/5005/chrome/browser/sync/test/integration/sync_extension_helper.cc File chrome/browser/sync/test/integration/sync_extension_helper.cc (right): https://chromiumcodereview.appspot.com/12578008/diff/5005/chrome/browser/sync/test/integration/sync_extension_helper.cc#newcode50 chrome/browser/sync/test/integration/sync_extension_helper.cc:50: std::string SyncExtensionHelper::NameToId(const std::string& name) { On 2013/03/22 20:26:50, Jeffrey ...
7 years, 9 months ago (2013-03-22 21:33:31 UTC) #6
Jeffrey Yasskin
lgtm
7 years, 9 months ago (2013-03-22 21:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12578008/43001
7 years, 9 months ago (2013-03-22 22:30:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12578008/43001
7 years, 9 months ago (2013-03-23 15:02:03 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 21:25:21 UTC) #10
Message was sent while issue was closed.
Change committed as 190078

Powered by Google App Engine
This is Rietveld 408576698