Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: lib/src/chunk_builder.dart

Issue 1257793003: Add regression test for previously fixed bug. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/regression/0300/0388.unit » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/chunk_builder.dart
diff --git a/lib/src/chunk_builder.dart b/lib/src/chunk_builder.dart
index 25d36cbe54e2b534ea4c86133f477d0e480ae4e9..c7ff91bb200efe5ed2b961456910e6b34da1e193 100644
--- a/lib/src/chunk_builder.dart
+++ b/lib/src/chunk_builder.dart
@@ -511,13 +511,6 @@ class ChunkBuilder {
// If there is a hard newline within the block, force the surrounding rule
// for it so that we apply that constraint.
- // TODO(rnystrom): This does the wrong thing when there is are multiple
- // block arguments. We correctly force the rule, but then it gets popped
- // off the writer's stack and it forgets it was forced. Can repro with:
- //
- // longFunctionName(
- // [longElementName, longElementName, longElementName],
- // [short]);
if (forceSplit) _parent.forceRules();
// Write the split for the block contents themselves.
« no previous file with comments | « no previous file | test/regression/0300/0388.unit » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698