ui/views/cocoa/bridged_content_view.mm - Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/cocoa/bridged_content_view.mm

diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm

index 3a3e83962f17744628618a60069066f79731fb5e..0a4b25796790c6c0aa92350d1710839250849c42 100644

--- a/ui/views/cocoa/bridged_content_view.mm

+++ b/ui/views/cocoa/bridged_content_view.mm

@@ -172,7 +172,7 @@ bool DispatchEventToMenu(views::Widget* widget, ui::KeyboardCode key_code) {

if (DispatchEventToMenu(hostedView_->GetWidget(), event.key_code()))

return;

- hostedView_->GetWidget()->GetInputMethod()->DispatchKeyEvent(event);

+ hostedView_->GetWidget()->GetInputMethod()->DispatchKeyEvent(&event);

}

- (void)handleAction:(int)commandId

@@ -193,7 +193,7 @@ bool DispatchEventToMenu(views::Widget* widget, ui::KeyboardCode key_code) {

// Generate a synthetic event with the keycode toolkit-views expects.

ui::KeyEvent event(ui::ET_KEY_PRESSED, keyCode, domCode, eventFlags);

- hostedView_->GetWidget()->GetInputMethod()->DispatchKeyEvent(event);

+ hostedView_->GetWidget()->GetInputMethod()->DispatchKeyEvent(&event);

}

- (void)undo:(id)sender {

« no previous file with comments | « ui/keyboard/keyboard_util.cc ('k') | ui/views/cocoa/bridged_native_widget.h » ('j') | no next file with comments »