Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: ui/base/ime/input_method_win.h

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_minimal.cc ('k') | ui/base/ime/input_method_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_win.h
diff --git a/ui/base/ime/input_method_win.h b/ui/base/ime/input_method_win.h
index 66df7b350f0841043097aeb059b53bff42d76327..4814f269c2fe96a397f965dcf08641c7eba1428e 100644
--- a/ui/base/ime/input_method_win.h
+++ b/ui/base/ime/input_method_win.h
@@ -21,14 +21,13 @@ class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
public:
InputMethodWin(internal::InputMethodDelegate* delegate,
HWND toplevel_window_handle);
- ~InputMethodWin() override;
// Overridden from InputMethod:
void OnFocus() override;
void OnBlur() override;
bool OnUntranslatedIMEMessage(const base::NativeEvent& event,
NativeEventResult* result) override;
- bool DispatchKeyEvent(const ui::KeyEvent& event) override;
+ void DispatchKeyEvent(ui::KeyEvent* event) override;
void OnTextInputTypeChanged(const TextInputClient* client) override;
void OnCaretBoundsChanged(const TextInputClient* client) override;
void CancelComposition(const TextInputClient* client) override;
@@ -93,7 +92,7 @@ class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
// to be ready for receiving keyboard input.
bool IsWindowFocused(const TextInputClient* client) const;
- bool DispatchFabricatedKeyEvent(const ui::KeyEvent& event);
+ void DispatchFabricatedKeyEvent(ui::KeyEvent* event);
// Asks the client to confirm current composition text.
void ConfirmCompositionText();
@@ -134,12 +133,6 @@ class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase {
// propagation (e.g. triggered an accelerator).
bool suppress_next_char_;
- // The pointer to a boolean value which indicates whether this InputMethod
- // instance is destroyed. This is used in DispatchKeyEvent to detect whether
- // DispatchKeyEventPostIME will cause destruction of this InputMethod
- // instance. See crbug.com/513917.
- bool* destroyed_ptr_;
-
DISALLOW_COPY_AND_ASSIGN(InputMethodWin);
};
« no previous file with comments | « ui/base/ime/input_method_minimal.cc ('k') | ui/base/ime/input_method_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698