Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: ui/base/ime/input_method_chromeos.h

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_base_unittest.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_chromeos.h
diff --git a/ui/base/ime/input_method_chromeos.h b/ui/base/ime/input_method_chromeos.h
index da1b12ba5ef58ed7cdd3358d1b2e8f7a798e1178..d632bf4405a7ccfd7dad59a8ec7c024690bd995d 100644
--- a/ui/base/ime/input_method_chromeos.h
+++ b/ui/base/ime/input_method_chromeos.h
@@ -32,7 +32,7 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
void OnBlur() override;
bool OnUntranslatedIMEMessage(const base::NativeEvent& event,
NativeEventResult* result) override;
- bool DispatchKeyEvent(const ui::KeyEvent& event) override;
+ void DispatchKeyEvent(ui::KeyEvent* event) override;
void OnTextInputTypeChanged(const TextInputClient* client) override;
void OnCaretBoundsChanged(const TextInputClient* client) override;
void CancelComposition(const TextInputClient* client) override;
@@ -47,7 +47,7 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
CompositionText* out_composition) const;
// Process a key returned from the input method.
- virtual void ProcessKeyEventPostIME(const ui::KeyEvent& event,
+ virtual void ProcessKeyEventPostIME(ui::KeyEvent* event,
bool handled);
// Resets context and abandon all pending results and key events.
@@ -73,14 +73,14 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
// A VKEY_PROCESSKEY may be dispatched to the EventTargets.
// It returns the result of whether the event has been stopped propagation
// when dispatching post IME.
- bool ProcessFilteredKeyPressEvent(const ui::KeyEvent& event);
+ void ProcessFilteredKeyPressEvent(ui::KeyEvent* event);
// Processes a key event that was not filtered by the input method.
- void ProcessUnfilteredKeyPressEvent(const ui::KeyEvent& event);
+ void ProcessUnfilteredKeyPressEvent(ui::KeyEvent* event);
// Sends input method result caused by the given key event to the focused text
// input client.
- void ProcessInputMethodResult(const ui::KeyEvent& event, bool filtered);
+ void ProcessInputMethodResult(ui::KeyEvent* event, bool filtered);
// Checks if the pending input method result needs inserting into the focused
// text input client as a single character.
@@ -90,7 +90,8 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
bool HasInputMethodResult() const;
// Sends a fake key event for IME composing without physical key events.
- void SendFakeProcessKeyEvent(bool pressed) const;
+ // Returns true if the faked key event is stopped propagation.
+ bool SendFakeProcessKeyEvent(bool pressed) const;
// Passes keyevent and executes character composition if necessary. Returns
// true if character composer comsumes key event.
@@ -107,7 +108,7 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS
void HidePreeditText();
// Callback function for IMEEngineHandlerInterface::ProcessKeyEvent.
- void ProcessKeyEventDone(const ui::KeyEvent* event, bool is_handled);
+ void ProcessKeyEventDone(ui::KeyEvent* event, bool is_handled);
// Returns whether an non-password input field is focused.
bool IsNonPasswordInputFieldFocused();
« no previous file with comments | « ui/base/ime/input_method_base_unittest.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698