mandoline/ui/aura/native_widget_view_manager.cc - Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/aura/native_widget_view_manager.cc

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mandoline/ui/aura/native_widget_view_manager.cc

diff --git a/mandoline/ui/aura/native_widget_view_manager.cc b/mandoline/ui/aura/native_widget_view_manager.cc

index cdc03b3898bb7dda387a7df0f2f8e2ba34ab4e74..1665d18c977a3b9ed6c293541440abd2c3ae3354 100644

--- a/mandoline/ui/aura/native_widget_view_manager.cc

+++ b/mandoline/ui/aura/native_widget_view_manager.cc

@@ -108,8 +108,7 @@ void NativeWidgetViewManager::OnViewInputEvent(mojo::View* view,

if (ui_event->IsKeyEvent()) {

window_tree_host_->GetInputMethod()->DispatchKeyEvent(

- *static_cast<ui::KeyEvent*>(ui_event.get()));

- ui_event->StopPropagation();

+ static_cast<ui::KeyEvent*>(ui_event.get()));

} else {

window_tree_host_->SendEventToProcessor(ui_event.get());

}

« no previous file with comments | « mandoline/ui/aura/input_method_mandoline.cc ('k') | ui/aura/window_tree_host.h » ('j') | no next file with comments »