mandoline/ui/aura/input_method_mandoline.h - Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/aura/input_method_mandoline.h

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mandoline/ui/aura/input_method_mandoline.h

diff --git a/mandoline/ui/aura/input_method_mandoline.h b/mandoline/ui/aura/input_method_mandoline.h

index a7cfbe24720dd7fa5828e6ea43e915f62a442119..9da4653d5de1cf53db513fbadb26ca801b93dd68 100644

--- a/mandoline/ui/aura/input_method_mandoline.h

+++ b/mandoline/ui/aura/input_method_mandoline.h

@@ -18,7 +18,7 @@ class InputMethodMandoline : public ui::InputMethodBase {

// Overridden from ui::InputMethod:

bool OnUntranslatedIMEMessage(const base::NativeEvent& event,

NativeEventResult* result) override;

- bool DispatchKeyEvent(const ui::KeyEvent& event) override;

+ void DispatchKeyEvent(ui::KeyEvent* event) override;

void OnCaretBoundsChanged(const ui::TextInputClient* client) override;

void CancelComposition(const ui::TextInputClient* client) override;

void OnInputLocaleChanged() override;

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | mandoline/ui/aura/input_method_mandoline.cc » ('j') | no next file with comments »