Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: ash/host/ash_window_tree_host_x11.cc

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/host/ash_window_tree_host_x11.h ('k') | ash/ime/input_method_event_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/host/ash_window_tree_host_x11.cc
diff --git a/ash/host/ash_window_tree_host_x11.cc b/ash/host/ash_window_tree_host_x11.cc
index 1999052530ebac1da66e86527c4d23cc592c6a10..a6971b5cae77d15f3d57308a5569a6b73eb76b7c 100644
--- a/ash/host/ash_window_tree_host_x11.cc
+++ b/ash/host/ash_window_tree_host_x11.cc
@@ -236,15 +236,14 @@ void AshWindowTreeHostX11::TranslateAndDispatchLocatedEvent(
SendEventToProcessor(event);
}
-bool AshWindowTreeHostX11::DispatchKeyEventPostIME(const ui::KeyEvent& event) {
- ui::KeyEvent event_copy(event);
+ui::EventDispatchDetails AshWindowTreeHostX11::DispatchKeyEventPostIME(
+ ui::KeyEvent* event) {
input_method_handler()->SetPostIME(true);
ui::EventDispatchDetails details =
- event_processor()->OnEventFromSource(&event_copy);
- if (details.dispatcher_destroyed)
- return true;
- input_method_handler()->SetPostIME(false);
- return event_copy.stopped_propagation();
+ event_processor()->OnEventFromSource(event);
+ if (!details.dispatcher_destroyed)
+ input_method_handler()->SetPostIME(false);
+ return details;
}
#if defined(OS_CHROMEOS)
« no previous file with comments | « ash/host/ash_window_tree_host_x11.h ('k') | ash/ime/input_method_event_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698