Refactoring for the InputMethod & InputMethodDelegate interfaces.

ui/base/ime/remote_input_method_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/ime/remote_input_method_win.h"
 
 #include "base/command_line.h"
 #include "base/observer_list.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/metro.h"
@@ skipping 161 matching lines @@
   void DetachTextInputClient(TextInputClient* client) override {
     if (text_input_client_ != client)
       return;
     SetFocusedTextInputClient(NULL);
   }
 
   TextInputClient* GetTextInputClient() const override {
     return text_input_client_;
   }
 
-  bool DispatchKeyEvent(const ui::KeyEvent& event) override {
-    if (event.HasNativeEvent()) {
-      const base::NativeEvent& native_key_event = event.native_event();
-      if (native_key_event.message != WM_CHAR)
-        return false;
-      if (!text_input_client_)
-        return false;
-      text_input_client_->InsertChar(
-          static_cast<base::char16>(native_key_event.wParam),
-          ui::GetModifiersFromKeyState());
-      return true;
+  void DispatchKeyEvent(ui::KeyEvent* event) override {
+    if (event->HasNativeEvent()) {
+      const base::NativeEvent& native_key_event = event->native_event();
+      if (native_key_event.message == WM_CHAR && text_input_client_) {
+        text_input_client_->InsertChar(
+            static_cast<base::char16>(native_key_event.wParam),
+            ui::GetModifiersFromKeyState());
+        event->StopPropagation();
+      }
+      return;
     }
 
-    if (event.is_char()) {
+    if (event->is_char()) {
       if (text_input_client_) {
         text_input_client_->InsertChar(
-            event.GetCharacter(),
+            event->GetCharacter(),
             ui::GetModifiersFromKeyState());
       }
-      return true;
+      event->StopPropagation();
+      return;
     }
-    if (!delegate_)
-      return false;
-    return delegate_->DispatchKeyEventPostIME(event);
+    if (delegate_)
+      ignore_result(delegate_->DispatchKeyEventPostIME(event));
   }
 
   void OnTextInputTypeChanged(const TextInputClient* client) override {
     if (!text_input_client_ || text_input_client_ != client)
       return;
     std::vector<int32> prev_input_scopes;
     std::swap(input_scopes_, prev_input_scopes);
     input_scopes_ = GetInputScopesAsInt(client->GetTextInputType(),
                                         client->GetTextInputMode());
     if (input_scopes_ != prev_input_scopes && remote_delegate_) {
@@ skipping 159 matching lines @@
   return make_scoped_ptr(new RemoteInputMethodWin(delegate));
 }
 
 // static
 RemoteInputMethodPrivateWin* RemoteInputMethodPrivateWin::Get(
     InputMethod* input_method) {
   return GetPrivate(input_method);
 }
 
 }  // namespace ui