Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: ui/base/ime/input_method_mac.mm

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/input_method_mac.h ('k') | ui/base/ime/input_method_minimal.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/ime/input_method_mac.h" 5 #include "ui/base/ime/input_method_mac.h"
6 6
7 namespace ui { 7 namespace ui {
8 8
9 InputMethodMac::InputMethodMac(internal::InputMethodDelegate* delegate) { 9 InputMethodMac::InputMethodMac(internal::InputMethodDelegate* delegate) {
10 SetDelegate(delegate); 10 SetDelegate(delegate);
11 } 11 }
12 12
13 InputMethodMac::~InputMethodMac() { 13 InputMethodMac::~InputMethodMac() {
14 } 14 }
15 15
16 bool InputMethodMac::OnUntranslatedIMEMessage(const base::NativeEvent& event, 16 bool InputMethodMac::OnUntranslatedIMEMessage(const base::NativeEvent& event,
17 NativeEventResult* result) { 17 NativeEventResult* result) {
18 return false; 18 return false;
19 } 19 }
20 20
21 bool InputMethodMac::DispatchKeyEvent(const ui::KeyEvent& event) { 21 void InputMethodMac::DispatchKeyEvent(ui::KeyEvent* event) {
22 // This is used on Mac only to dispatch events post-IME. 22 // This is used on Mac only to dispatch events post-IME.
23 return DispatchKeyEventPostIME(event); 23 ignore_result(DispatchKeyEventPostIME(event));
24 } 24 }
25 25
26 void InputMethodMac::OnCaretBoundsChanged(const TextInputClient* client) { 26 void InputMethodMac::OnCaretBoundsChanged(const TextInputClient* client) {
27 } 27 }
28 28
29 void InputMethodMac::CancelComposition(const TextInputClient* client) { 29 void InputMethodMac::CancelComposition(const TextInputClient* client) {
30 } 30 }
31 31
32 void InputMethodMac::OnInputLocaleChanged() { 32 void InputMethodMac::OnInputLocaleChanged() {
33 } 33 }
34 34
35 std::string InputMethodMac::GetInputLocale() { 35 std::string InputMethodMac::GetInputLocale() {
36 return ""; 36 return "";
37 } 37 }
38 38
39 bool InputMethodMac::IsCandidatePopupOpen() const { 39 bool InputMethodMac::IsCandidatePopupOpen() const {
40 // There seems to be no way to tell if a candidate window is open. 40 // There seems to be no way to tell if a candidate window is open.
41 return false; 41 return false;
42 } 42 }
43 43
44 } // namespace ui 44 } // namespace ui
OLDNEW
« no previous file with comments | « ui/base/ime/input_method_mac.h ('k') | ui/base/ime/input_method_minimal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698