Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Side by Side Diff: ui/aura/window_tree_host.h

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mandoline/ui/aura/native_widget_view_manager.cc ('k') | ui/aura/window_tree_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_AURA_WINDOW_TREE_HOST_H_ 5 #ifndef UI_AURA_WINDOW_TREE_HOST_H_
6 #define UI_AURA_WINDOW_TREE_HOST_H_ 6 #define UI_AURA_WINDOW_TREE_HOST_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/event_types.h" 10 #include "base/event_types.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // can make sure the correct InputMethod instance processes the key event no 137 // can make sure the correct InputMethod instance processes the key event no
138 // matter which WindowTreeHost is the target for event. Please refer to the 138 // matter which WindowTreeHost is the target for event. Please refer to the
139 // test: ExtendedDesktopTest.KeyEventsOnLockScreen. 139 // test: ExtendedDesktopTest.KeyEventsOnLockScreen.
140 // 140 //
141 // TODO(shuchen): remove this method after above reasons become invalid. 141 // TODO(shuchen): remove this method after above reasons become invalid.
142 // A possible solution is to make sure DrmWindowHost can find the correct 142 // A possible solution is to make sure DrmWindowHost can find the correct
143 // WindowTreeHost to dispatch events. 143 // WindowTreeHost to dispatch events.
144 void SetSharedInputMethod(ui::InputMethod* input_method); 144 void SetSharedInputMethod(ui::InputMethod* input_method);
145 145
146 // Overridden from ui::internal::InputMethodDelegate: 146 // Overridden from ui::internal::InputMethodDelegate:
147 bool DispatchKeyEventPostIME(const ui::KeyEvent& event) override; 147 ui::EventDispatchDetails DispatchKeyEventPostIME(
148 ui::KeyEvent* event) override;
148 149
149 // Returns the EventSource responsible for dispatching events to the window 150 // Returns the EventSource responsible for dispatching events to the window
150 // tree. 151 // tree.
151 virtual ui::EventSource* GetEventSource() = 0; 152 virtual ui::EventSource* GetEventSource() = 0;
152 153
153 // Returns the accelerated widget. 154 // Returns the accelerated widget.
154 virtual gfx::AcceleratedWidget GetAcceleratedWidget() = 0; 155 virtual gfx::AcceleratedWidget GetAcceleratedWidget() = 0;
155 156
156 // Shows the WindowTreeHost. 157 // Shows the WindowTreeHost.
157 void Show(); 158 void Show();
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 239
239 // Whether the InputMethod instance is owned by this WindowTreeHost. 240 // Whether the InputMethod instance is owned by this WindowTreeHost.
240 bool owned_input_method_; 241 bool owned_input_method_;
241 242
242 DISALLOW_COPY_AND_ASSIGN(WindowTreeHost); 243 DISALLOW_COPY_AND_ASSIGN(WindowTreeHost);
243 }; 244 };
244 245
245 } // namespace aura 246 } // namespace aura
246 247
247 #endif // UI_AURA_WINDOW_TREE_HOST_H_ 248 #endif // UI_AURA_WINDOW_TREE_HOST_H_
OLDNEW
« no previous file with comments | « mandoline/ui/aura/native_widget_view_manager.cc ('k') | ui/aura/window_tree_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698