Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 12575008: Dump stats of memory pages which are hooked, but absent from /proc/<pid>/maps. (Closed)

Created:
7 years, 9 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org, willchan no longer on Chromium
Visibility:
Public.

Description

Dump stats of memory pages which are hooked, but absent from /proc/<pid>/maps. BUG=189114 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188272

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M third_party/tcmalloc/chromium/src/deep-heap-profile.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/deep-heap-profile.cc View 3 chunks +36 lines, -0 lines 0 comments Download
M tools/deep_memory_profiler/dmprof.py View 2 chunks +3 lines, -2 lines 2 comments Download
M tools/deep_memory_profiler/policy.l0.json View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/deep_memory_profiler/policy.l1.json View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/deep_memory_profiler/policy.l2.json View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/deep_memory_profiler/policy.t0.json View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi glider, Could you take a look at this when you have time? It should ...
7 years, 9 months ago (2013-03-13 04:28:20 UTC) #1
Alexander Potapenko
LGTM with nit. https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dmprof.py File tools/deep_memory_profiler/dmprof.py (right): https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dmprof.py#newcode987 tools/deep_memory_profiler/dmprof.py:987: 'absent': 'absent_committed', I wonder if you ...
7 years, 9 months ago (2013-03-13 13:03:19 UTC) #2
Dai Mikurube (NOT FULLTIME)
Thank you, Alexander. https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dmprof.py File tools/deep_memory_profiler/dmprof.py (right): https://codereview.chromium.org/12575008/diff/1/tools/deep_memory_profiler/dmprof.py#newcode987 tools/deep_memory_profiler/dmprof.py:987: 'absent': 'absent_committed', On 2013/03/13 13:03:19, Alexander ...
7 years, 9 months ago (2013-03-14 11:26:22 UTC) #3
willchan no longer on Chromium
LGTM, I only looked at the tcmalloc code and not the tools code.
7 years, 9 months ago (2013-03-14 16:17:54 UTC) #4
Dai Mikurube (NOT FULLTIME)
Thanks, Alexander and Will. Committing.
7 years, 9 months ago (2013-03-15 01:02:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/12575008/1
7 years, 9 months ago (2013-03-15 01:08:44 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=109230
7 years, 9 months ago (2013-03-15 02:53:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/12575008/1
7 years, 9 months ago (2013-03-15 04:23:38 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 07:07:21 UTC) #9
Message was sent while issue was closed.
Change committed as 188272

Powered by Google App Engine
This is Rietveld 408576698