make BoxLayout use and respect GetHeightForWidth().

make BoxLayout use and respect GetHeightForWidth() (for vertical layouts).

BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188288

[sky, 2013-03-13 14:03:03]

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout.cc
File ui/views/layout/box_layout.cc (right):

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout...
ui/views/layout/box_layout.cc:82: gfx::Size BoxLayout::GetPreferredSize(View*
host) {
You should also override GetPreferredSizeForWidth now.

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout...
File ui/views/layout/box_layout_unittest.cc (right):

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout...
ui/views/layout/box_layout_unittest.cc:42: };
DISALLOW_...

[Evan Stade, 2013-03-13 23:49:56]

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout.cc
File ui/views/layout/box_layout.cc (right):

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout...
ui/views/layout/box_layout.cc:82: gfx::Size BoxLayout::GetPreferredSize(View*
host) {
On 2013/03/13 14:03:03, sky wrote:
> You should also override GetPreferredSizeForWidth now.

done, although I didn't add an implementation for horizontal layouts, which
would require re-using the code in Layout(). IMO we can cross that bridge when
we come to it.

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout...
File ui/views/layout/box_layout_unittest.cc (right):

https://codereview.chromium.org/12575005/diff/4001/ui/views/layout/box_layout...
ui/views/layout/box_layout_unittest.cc:42: };
On 2013/03/13 14:03:03, sky wrote:
> DISALLOW_...

Done.

[sky, 2013-03-14 00:13:09]

Do Labels and Links have the same preferred height now?

[Evan Stade, 2013-03-14 01:14:23]

On 2013/03/14 00:13:09, sky wrote:
> Do Labels and Links have the same preferred height now?

no, this change does not affect links or labels.

[sky, 2013-03-14 14:50:01]

Not sure how this happened, but that comment was meant for your other view
(StyledLabel). I'll post it there.

[sky, 2013-03-14 14:51:13]

LGTM

[commit-bot: I haz the power, 2013-03-14 18:23:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/12575005/10001

[commit-bot: I haz the power, 2013-03-15 07:38:41]

Change committed as 188288