Escape key should exit the fullscreen mode when playing a video.

Escape key should exit the fullscreen mode when playing a video.

This patch makes escape closing the fullscreen mode, which seem to be intuitive.

TEST=Play video, go to full screen, press escape.
BUG=161610
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187509

[mtomasz, 2013-03-08 05:17:05]

@haruki: PTAL.

[mtomasz, 2013-03-11 03:54:57]

@haruki: Ping.

[Haruki Sato, 2013-03-11 17:05:41]

lgtm

I just found we are using both keyCode and keyIdentifier in file_manager code.
We might want to keep it in mind that keyIdentifier feature might be
changed/removed in some future.
I think it's OK as long as it works.

[mtomasz, 2013-03-12 01:18:00]

On 2013/03/11 17:05:41, Haruki Sato wrote:
> lgtm
> 
> I just found we are using both keyCode and keyIdentifier in file_manager code.
> We might want to keep it in mind that keyIdentifier feature might be
> changed/removed in some future.
> I think it's OK as long as it works.

Good catch. I've filed crbug.com/182117 to migrate it to event.key. Suprisingly,
KeyboardEvent.keyCode is also deprecated in favor of KeyboardEvent.key, which is
not yet implemented.

[commit-bot: I haz the power, 2013-03-12 01:19:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12575004/1

[commit-bot: I haz the power, 2013-03-12 04:48:49]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-12 04:51:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12575004/1

[commit-bot: I haz the power, 2013-03-12 05:48:37]

Change committed as 187509